607981 - Unified Inbox doesn't work anymore − no way to set it back up

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Jonathan Protzenko [:protz]]

Attachment: Prevents the dialog from being totally unusable

So I'm probably hitting bug 578148 but the weird thing is, in my case, the "Properties" dialog of the smart inbox was totally broken, which would prevent me from properly restoring the smart inbox after deleting the msf files.

Looks like passing an empty string as the RDF resource makes the whole thing crash. Patch attached.

Comment 1

[David :Bienvenu]

Comment on attachment 486636 [details] [diff] [review]
Prevents the dialog from being totally unusable

Oh, I bet you got a searchFolderUri with ",," in it, or something like that, so you got an empty folderUri.

Comment 2

[David :Bienvenu]

Is it possible that you ran with a 3.0.x build when you removed the account?

Comment 3

[Jonathan Protzenko [:protz]]

(In reply to comment #1)
> Comment on attachment 486636 [details] [diff] [review]
> Prevents the dialog from being totally unusable
> 
> Oh, I bet you got a searchFolderUri with ",," in it, or something like that, so
> you got an empty folderUri.

Sounds likely.

(In reply to comment #2)
> Is it possible that you ran with a 3.0.x build when you removed the account?

Hard to say. I tend to keep my dev profiles running around for a long time, so that's a possibility, yes.

Comment 4

[Jonathan Protzenko [:protz]]

Comment on attachment 486636 [details] [diff] [review]
Prevents the dialog from being totally unusable

I think it's worth having this on 3.1 since msf corruption does happen in there. It'd be a shame for users not to be able to manually restore their smart inbox.

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/e8e2938b6e53

Comment 6

[Ludovic Hirlimann [:Usul]]

(In reply to comment #0)
 
> Looks like passing an empty string as the RDF resource makes the whole thing
> crash. Patch attached.

Do you have the crash signature for that crash ?

Comment 7

[Jonathan Protzenko [:protz]]

Sorry, didn't mean crash. Just meant: makes the whole thing fail. (Error in the rror console).

Comment 8

[Mark Banner (:standard8)]

Checked into 1.9.2: http://hg.mozilla.org/releases/comm-1.9.2/rev/365301ed453f