Closed Bug 608156 Opened 10 years ago Closed 9 years ago

Run WeaveCrypto in Chrome Worker

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED WONTFIX
Tracking Status
blocking2.0 --- -
fennec - ---

People

(Reporter: philikon, Unassigned)

References

Details

No description provided.
Blocks: 592372
Depends on: 608170
Depends on: 608171
Next time please clone!

570619 blocked b2 / b8 it was marked wontfix and this bug was filed.  Bringing over the same blocking flags.
blocking2.0: --- → beta8+
tracking-fennec: --- → 2.0b2+
Blocks: 592375
tracking-fennec: 2.0b2+ → 2.0b3+
Blocks: 609376
Philipp - assigning to you so it's assigned to someone
Assignee: nobody → philipp
blocking2.0: beta8+ → betaN+
tracking-fennec: 2.0b3+ → 2.0b4+
Depends on: 615153
tracking-fennec: 2.0b4+ → 2.0+
Can someone please provide data on how much time we are spending on doing crypto for some profile (and how many records are being decoded?) so we can determine if we actually need to block on this?
(In reply to comment #3)
> Can someone please provide data on how much time we are spending on doing
> crypto for some profile (and how many records are being decoded?) so we can
> determine if we actually need to block on this?

We're planning on doing some timing work -- Bug 624485, IIRC. Numbers for crypto will be part of this. I'll tackle this after I'm done with MP/wizard work, assuming nothing else drags me away.
(In reply to comment #4)
> (In reply to comment #3)
> > Can someone please provide data on how much time we are spending on doing
> > crypto for some profile (and how many records are being decoded?) so we can
> > determine if we actually need to block on this?
> 
> We're planning on doing some timing work -- Bug 624485, IIRC. Numbers for
> crypto will be part of this. I'll tackle this after I'm done with MP/wizard
> work, assuming nothing else drags me away.

bug 624485 isnt flagged to block firefox or fennec final, so please indicate if that should be.  otherwise, i think the blocking priority on this bug will need to change if its dependent on the other.
(In reply to comment #5)

> > We're planning on doing some timing work -- Bug 624485, IIRC. Numbers for
> > crypto will be part of this. I'll tackle this after I'm done with MP/wizard
> > work, assuming nothing else drags me away.
> 
> bug 624485 isnt flagged to block firefox or fennec final, so please indicate if
> that should be.

It shouldn't be. The timing numbers are just to make people happy and indicate areas for further work.

> otherwise, i think the blocking priority on this bug will need
> to change if its dependent on the other.

I wouldn't call it a formal dependency; more 'sibling'.
Assignee: philipp → rnewman
Added some preliminary instrumentation results in Bug 624485. It looks like NSS operations *and their callers*, all the way up the stack, take no more than 10% of the total time of a sync, and there are many more opportunities for improvement prior to using workers.
From the results outlined in bug 624485 comment 1, this is likely more trouble than it's worth.  Because we decrypt one record per call, we're talking about thousands of small calls, none of which are long enough on their own to block the main thread for any meaningful amount of time. Without a bulk API in NSS, using ChromeWorker for these ops likely add even more overhead with little benefit.

Instead, we're going to focus on making the crypto pieces much more efficient with the intent of reducing overall time spent in crypto.
Assignee: rnewman → nobody
Status: NEW → RESOLVED
blocking2.0: betaN+ → -
tracking-fennec: 2.0+ → 2.0-
Closed: 9 years ago
Resolution: --- → WONTFIX
Component: Firefox Sync: Crypto → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.