Closed Bug 608173 Opened 10 years ago Closed 10 years ago
Build system should provide an intelligible error when switching from gmake to pymake or vice versa on an absolutely configured objdir
We should also point people to an MDC page or similar explaining that they want to do a relative configure if they want to switch with impunity.
(In reply to comment #0) > We should also point people to an MDC page or similar explaining that they want > to do a relative configure if they want to switch with impunity. Have a particular page in mind? [I don't really want to direct people to a page without a concise one already being written, and I hate Deki so much that I won't write it]
Assignee: nobody → bugspam.Callek
FTR I hate Deki too, but I wrote https://developer.mozilla.org/en/Gmake_vs._Pymake
This incorporates the patch in 485411, as well as adds a test for the opposite case (GNUMake from Pymake) and adds a pointer at the MDC page. Not tested on my end [I won't be able to for a few days min] due to my current builds being relative dirs and pymake.
Comment on attachment 486834 [details] [diff] [review] v1 (exported) for checkin As we discovered on IRC, we'll have to move this into autoconf.mk.in to make it work.
Comment on attachment 487131 [details] [diff] [review] v2 Add it to js/src's too.
Attachment #487131 - Flags: review?(khuey) → review+
with js/src. r+=khuey
10 years ago
Comment on attachment 487171 [details] [diff] [review] v2.1 for checkin Actually, we need to test to make sure that we're on Windows. We don't want to reject a path like /home/khuey/mozilla-central on Linux.
Attachment #487171 - Flags: review+ → review-
This should do it. Wrapping using HOST_OS_ARCH since we only care about _what_ is building, not _where_ its target is.
..and from the right repo this time.
Comment on attachment 487279 [details] [diff] [review] v2.2 (from right repo) Nit: Use GNU Make (not GNU-Make) in both places, use Pymake or pymake (don't capitalize the m) r=me
Attachment #487279 - Flags: review?(khuey) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Do it for comm-central
Attachment #487814 - Flags: review?(kairo)
Comment on attachment 487814 [details] [diff] [review] c-c port >+$(error Windows-style srcdir being used with GNU make. Did you mean to run $(topsrcdir)/build/pymake/make.py instead? [see-also: https://developer.mozilla.org/en/Gmake_vs._Pymake]) Isn't this $(topsrcdir)/mozilla/build/pymake/make.py instead?
Attachment #487814 - Flags: review?(kairo) → review+
You need to log in before you can comment on or make changes to this bug.