608173 - Build system should provide an intelligible error when switching from gmake to pymake or vice versa on an absolutely configured objdir

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

We should also point people to an MDC page or similar explaining that they want to do a relative configure if they want to switch with impunity.

Comment 1

[Justin Wood (:Callek)]

(In reply to comment #0)
> We should also point people to an MDC page or similar explaining that they want
> to do a relative configure if they want to switch with impunity.

Have a particular page in mind? [I don't really want to direct people to a page without a concise one already being written, and I hate Deki so much that I won't write it]

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

FTR I hate Deki too, but I wrote https://developer.mozilla.org/en/Gmake_vs._Pymake

Comment 3

[Justin Wood (:Callek)]

Attachment: v1 (exported) for checkin

This incorporates the patch in 485411, as well as adds a test for the opposite case (GNUMake from Pymake) and adds a pointer at the MDC page.

Not tested on my end [I won't be able to for a few days min] due to my current builds being relative dirs and pymake.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 486834 [details] [diff] [review]
v1 (exported) for checkin

As we discovered on IRC, we'll have to move this into autoconf.mk.in to make it work.

Comment 5

[Justin Wood (:Callek)]

Attachment: v2

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 487131 [details] [diff] [review]
v2

Add it to js/src's too.

Comment 7

[Justin Wood (:Callek)]

Attachment: v2.1 for checkin

with js/src. r+=khuey

Comment 8

[Justin Wood (:Callek)]

Attachment: comm-central port

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 487171 [details] [diff] [review]
v2.1 for checkin

Actually, we need to test to make sure that we're on Windows.  We don't want to reject a path like /home/khuey/mozilla-central on Linux.

Comment 10

[Justin Wood (:Callek)]

Attachment: v2.2

This should do it. Wrapping using HOST_OS_ARCH since we only care about _what_ is building, not _where_ its target is.

Comment 11

[Justin Wood (:Callek)]

Attachment: v2.2 (from right repo)

..and from the right repo this time.

Comment 12

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 487279 [details] [diff] [review]
v2.2 (from right repo)

Nit: Use GNU Make (not GNU-Make) in both places, use Pymake or pymake (don't capitalize the m)

r=me

Comment 13

[Justin Wood (:Callek)]

http://hg.mozilla.org/mozilla-central/rev/20ff461fe1ca

Comment 14

[Justin Wood (:Callek)]

Attachment: c-c port

Do it for comm-central

Comment 15

[Robert Kaiser]

Comment on attachment 487814 [details] [diff] [review]
c-c port

>+$(error Windows-style srcdir being used with GNU make. Did you mean to run $(topsrcdir)/build/pymake/make.py instead? [see-also: https://developer.mozilla.org/en/Gmake_vs._Pymake])

Isn't this $(topsrcdir)/mozilla/build/pymake/make.py instead?

Comment 16

[Justin Wood (:Callek)]

http://hg.mozilla.org/comm-central/rev/6079fc2d2702