Closed Bug 608173 Opened 10 years ago Closed 10 years ago

Build system should provide an intelligible error when switching from gmake to pymake or vice versa on an absolutely configured objdir

Categories

(Firefox Build System :: General, defect)

x86
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: khuey, Assigned: Callek)

Details

Attachments

(2 files, 5 obsolete files)

We should also point people to an MDC page or similar explaining that they want to do a relative configure if they want to switch with impunity.
(In reply to comment #0)
> We should also point people to an MDC page or similar explaining that they want
> to do a relative configure if they want to switch with impunity.

Have a particular page in mind? [I don't really want to direct people to a page without a concise one already being written, and I hate Deki so much that I won't write it]
Assignee: nobody → bugspam.Callek
Attached patch v1 (exported) for checkin (obsolete) — Splinter Review
This incorporates the patch in 485411, as well as adds a test for the opposite case (GNUMake from Pymake) and adds a pointer at the MDC page.

Not tested on my end [I won't be able to for a few days min] due to my current builds being relative dirs and pymake.
Attachment #486834 - Flags: review?(khuey)
Comment on attachment 486834 [details] [diff] [review]
v1 (exported) for checkin

As we discovered on IRC, we'll have to move this into autoconf.mk.in to make it work.
Attachment #486834 - Flags: review?(khuey)
Attached patch v2 (obsolete) — Splinter Review
Attachment #486834 - Attachment is obsolete: true
Attachment #487131 - Flags: review?(khuey)
Comment on attachment 487131 [details] [diff] [review]
v2

Add it to js/src's too.
Attachment #487131 - Flags: review?(khuey) → review+
Attached patch v2.1 for checkin (obsolete) — Splinter Review
with js/src. r+=khuey
Attachment #487131 - Attachment is obsolete: true
Attachment #487171 - Flags: review+
Attached patch comm-central port (obsolete) — Splinter Review
Attachment #487172 - Flags: review?(bugzilla)
Attachment #487172 - Attachment is obsolete: true
Attachment #487172 - Flags: review?(bugzilla)
Comment on attachment 487171 [details] [diff] [review]
v2.1 for checkin

Actually, we need to test to make sure that we're on Windows.  We don't want to reject a path like /home/khuey/mozilla-central on Linux.
Attachment #487171 - Flags: review+ → review-
Attached patch v2.2 (obsolete) — Splinter Review
This should do it. Wrapping using HOST_OS_ARCH since we only care about _what_ is building, not _where_ its target is.
Attachment #487171 - Attachment is obsolete: true
Attachment #487278 - Flags: review?(khuey)
..and from the right repo this time.
Attachment #487278 - Attachment is obsolete: true
Attachment #487279 - Flags: review?(khuey)
Attachment #487278 - Flags: review?(khuey)
Comment on attachment 487279 [details] [diff] [review]
v2.2 (from right repo)

Nit: Use GNU Make (not GNU-Make) in both places, use Pymake or pymake (don't capitalize the m)

r=me
Attachment #487279 - Flags: review?(khuey) → review+
http://hg.mozilla.org/mozilla-central/rev/20ff461fe1ca
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attached patch c-c portSplinter Review
Do it for comm-central
Attachment #487814 - Flags: review?(kairo)
Comment on attachment 487814 [details] [diff] [review]
c-c port

>+$(error Windows-style srcdir being used with GNU make. Did you mean to run $(topsrcdir)/build/pymake/make.py instead? [see-also: https://developer.mozilla.org/en/Gmake_vs._Pymake])

Isn't this $(topsrcdir)/mozilla/build/pymake/make.py instead?
Attachment #487814 - Flags: review?(kairo) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.