608235 - Incorrect error message for undefined[undefined]

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Marc]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.11) Gecko/20101013 Ubuntu/10.04 (lucid) Firefox/3.6.11
Build Identifier: 

Evaluation of an expression equivalent to undefined[undefined] will throw an exception with following error message:

TypeError: Cannot read property "org.mozilla.javascript.Undefined@cd5f8b" from undefined

The "org.mozilla.javascript.Undefined@cd5f8b" is not good at all here!

Reproducible: Always

Comment 1

[Marc]

Attachment: Patch (with unit test) fixing the problem

Comment 2

[André Bargull [:anba]]

Pull request at https://github.com/mozilla/rhino/pull/79

Comment 3

[Hannes Wallnoefer]

Thanks André, I merged your pull request. 

While this will definitely improve error messages, one possible problem with it is that functions will now be rendered as source.

Either we should make error messages more terse (like spidermonkey) or we should add some function code shortening like we have in ScriptRuntime.notFunctionError().

Comment 4

[André Bargull [:anba]]

I'll prefer updating the error messages to correspond to the Spidermonkey error messages (again?), because that will also help with the Mozilla test suite. Currently multiple tests need to be skipped due to different error messages in Rhino compared to Spidermonkey.

Comment 5

[Hannes Wallnoefer]

A big +1 from me for adapting messages to Spidermonkey.