This is on current master. TEST-UNEXPECTED-FAIL | /Users/rnewman/moz/git/services/fx-sync/services/sync/tests/unit/test_utils_stackTrace.js | test failed (with xpcshell return code: 0), see following log: >>>>>>> ### XPCOM_MEM_LEAK_LOG defined -- logging leaks to /var/folders/2h/2hpSwqGYEfil3pmUrv+XmU+++TI/-Tmp-/tmpDQoxVJ/runxpcshelltests_leaks.log Setting the identity for passphrase Define some functions in well defined line positions for the test Make sure lazy constructor calling/assignment works TEST-INFO | (xpcshell/head.js) | test 1 pending Make sure functions, arguments, files are pretty printed in the trace Got trace: JS Stack trace: baz(2)@test_utils_stackTrace.js:4 < bar(1)@test_utils_stackTrace.js:3 < foo(0)@test_utils_stackTrace.js:2 < run_test()@test_utils_stackTrace.js:13 < _execute_test()@head.js:303 < @-e:1 TEST-PASS | /Users/rnewman/moz/git/services/fx-sync/services/sync/tests/unit/test_utils_stackTrace.js | [run_test : 19] JS Stack trace: baz(2)@test_utils_stackTrace.js:4 < bar(1)@test_utils_stackTrace.js:3 < foo(0)@test_utils_stackTrace.js:2 < run_test()@test_utils_stackTrace.js:13 < _execute_test()@head.js:303 < @-e:1 != String positions: -1 16 52 88 Make sure the desired messages show up TEST-UNEXPECTED-FAIL | /Users/rnewman/moz/git/services/fx-sync/services/sync/tests/unit/test_utils_stackTrace.js | false == true - See following stack: JS frame :: /Users/rnewman/moz/hg/mozilla-central/testing/xpcshell/head.js :: do_throw :: line 420 JS frame :: /Users/rnewman/moz/hg/mozilla-central/testing/xpcshell/head.js :: do_check_eq :: line 472 JS frame :: /Users/rnewman/moz/hg/mozilla-central/testing/xpcshell/head.js :: do_check_true :: line 484 JS frame :: /Users/rnewman/moz/git/services/fx-sync/services/sync/tests/unit/test_utils_stackTrace.js :: run_test :: line 28 JS frame :: /Users/rnewman/moz/hg/mozilla-central/testing/xpcshell/head.js :: _execute_test :: line 303 JS frame :: -e :: <TOP_LEVEL> :: line 1 TEST-INFO | (xpcshell/head.js) | exiting test WARNING: nsExceptionService ignoring thread destruction after shutdown: file /Users/rnewman/moz/hg/mozilla-central/xpcom/base/nsExceptionService.cpp, line 197 WARNING: OOPDeinit() without successful OOPInit(): file /Users/rnewman/moz/hg/mozilla-central/toolkit/crashreporter/nsExceptionHandler.cpp, line 1713 nsStringStats => mAllocCount: 2032 => mReallocCount: 314 => mFreeCount: 2032 => mShareCount: 6846 => mAdoptCount: 147 => mAdoptFreeCount: 147 <<<<<<< TEST-INFO | /Users/rnewman/moz/git/services/fx-sync/services/sync/tests/unit/test_utils_status.js | running test ... TEST-PASS | /Users/rnewman/moz/git/services/fx-sync/services/sync/tests/unit/test_utils_status.js | test passed TEST-INFO | /Users/rnewman/moz/git/services/fx-sync/services/sync/tests/unit/test_utils_utf8.js | running test ... TEST-PASS | /Users/rnewman/moz/git/services/fx-sync/services/sync/tests/unit/test_utils_utf8.js | test passed INFO | Result summary: INFO | Passed: 82 INFO | Failed: 1 make: *** [xpcshell-tests] Error 1 In summary: the test expects throw new Error(3); to generate a stacktrace that includes the string "Error(\"3\")", but it does not -- that error prints as "3", and nowhere in the stack printing code adds any wrapping string for errors. My guess would be that this behavior differs between harnesses (xpcshell, XULRunner, Fx itself), or that there's been some bitrot... but what do I know?
(In reply to comment #0) > This is on current master. master? SRSLY? :p > My guess would be that this behavior differs between harnesses (xpcshell, > XULRunner, Fx itself), or that there's been some bitrot... but what do I know? This isn't a matter of XULRunner vs. Fx but more like Gecko 1.9.x vs. 2.0. Looks like JägerMonkey broke this and they changed it upstream: http://hg.mozilla.org/mozilla-central/diff/66c8ad02543b/services/sync/tests/unit/test_utils_stackTrace.js We should backport this to fx-sync.
Depends on: 581263
OS: Mac OS X → All
Hardware: x86_64 → All
Summary: test_utils_stackTrace fails → test_utils_stackTrace fails after JM changes
Assignee: nobody → philipp
Attachment #486993 - Flags: review?(mconnor)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.