608448 - Warning in the error console when launching preferences pane

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Discovered whilst investigating bug 608446

When executing line 73 of firefox/testPreferences/testSetToCurrentPage.js:
prefs.openPreferencesDialog(prefDialogHomePageCallback);

From error console:
Warning: reference to undefined property window.documentLoaded
Source File: resource://mozmill/modules/controller.js
Line: 310

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Can you please dump the value of window right before the following line?
http://hg.mozilla.org/qa/mozmill-tests/file/default/shared-modules/utils.js#l400

Would be good to know if window is null or not.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Result:

 ** window: [object ChromeWindow]

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

That looks good. Dave, is this error gone with my proposed fix on bug 608446?

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

No, the error still occurs. To be clear, this occurs when the preferences dialog is opened, and doesn't appear to be related to any interactions with the dialog, including dismissing it.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Lets check this on your box, once we have time next week.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

It's only a strict warning which wouldn't block the next version of Mozmill. But exactly those failures will be fixed by my patch on bug 610134.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Should now be fixed with the final release of Mozmill 1.5.1.