608498 - Turn on fakelibs on Android

Status: RESOLVED DUPLICATE of bug 584474

(Firefox Build System :: General, defect)

Description

[Michael Wu [:mwu]]

This may be necessary for some work I want to do.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

You might be interested in glandium's patches in Bug 584474.

Comment 2

[Michael Wu [:mwu]]

Attachment: Turn on fakelibs on android

Seems to work. A little messy because android needs to be detected by OS_TARGET.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 489985 [details] [diff] [review]
Turn on fakelibs on android

Assuming this actually works, r=me. ;-)

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

what is the testing situation for fakelibs? how can we be sure this doesn't regress anything?

Comment 5

[Michael Wu [:mwu]]

(In reply to comment #4)
> what is the testing situation for fakelibs? how can we be sure this doesn't
> regress anything?

I've been using it for the last few days and it seems to work fine. Requesting approval now so we can get additional testing in the nightlies. I'm not sure what sort of regressions fakelibs could introduce.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

If it builds you should be fine.  We didn't have any fallout on Windows on m-c other than build/linkage errors.

Comment 7

[Michael Wu [:mwu]]

Yeah, I'd expect the problems to all show up at build time. There could be problems with symbol collisions or something but those directories shouldn't have fakelibs turned on.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 489985 [details] [diff] [review]
Turn on fakelibs on android

a=blassey

Comment 9

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/c708054e1f65

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

backed out per mwu's request http://hg.mozilla.org/mozilla-central/rev/829307640234

Comment 11

[Michael Wu [:mwu]]

http://tinderbox.mozilla.org/showlog.cgi?log=Mobile/1289946979.1289951119.31415.gz&fulltext=1

make[5]: execvp: /tools/android-ndk/build/prebuilt/linux-x86/arm-eabi-4.4.0/bin/arm-eabi-ar: Argument list too long
make[5]: *** [libgklayout.a] Error 127
make[5]: Leaving directory `/builds/slave/mozilla-central-mobile-browser-android-r7-build/build/mozilla-central/objdir/layout/build'

Apparently the systems we're building on are ancient and probably don't have support for unlimited length arg lists. Not sure why this would trigger with fakelibs on.. didn't we have pretty long lists of objects to link before?

Comment 12

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

For some reason you're getting absolute paths passed to ar.  That's almost certainly what's killing you.

Comment 13

[Michael Wu [:mwu]]

Not actively working on this.

Comment 14

[(not currently active) Ted Mielczarek]

Did bug 584474 fix this?

Comment 15

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Subsumed, perhaps.