Closed Bug 608544 Opened 14 years ago Closed 14 years ago

Don't console-spam a totally-expected warning about not getting the pref plugins.unloadASAP which has no default value

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

Attached patch FixSplinter Review
One of the charming aspects of the pref API is that it's an NS_ERROR_UNEXPECTED to get the value of a pref that doesn't exist. That means that every single time we hit http://mxr.mozilla.org/mozilla-central/source/modules/plugin/base/src/nsPluginHost.cpp?mark=310,316#304 during mochitest-4 or mochitest-chrome (or any others I haven't noticed, that also load plugins), we spam the log multiple times with the unexciting fact that "WARNING: Unable to retrieve pref: plugins.unloadASAP: file /builds/slave/tryserver-linux-debug/build/modules/plugin/base/src/nsPluginHost.cpp, line 316," not because the pref service is broken or anything bad or out of the ordinary has happened, but just because we disagree with the prefs service about the unexpected nature of getting a value for a pref that doesn't exist.
Attachment #487186 - Flags: review?(joshmoz)
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Comment on attachment 487186 [details] [diff] [review]
Fix

I've had this exact patch sitting around for a couple of weeks, waiting for a chance to slip it into another patch. r+, approval2.0+
Attachment #487186 - Flags: review?(joshmoz)
Attachment #487186 - Flags: review+
Attachment #487186 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/f07a66e227ec
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: