608544 - Don't console-spam a totally-expected warning about not getting the pref plugins.unloadASAP which has no default value

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix

One of the charming aspects of the pref API is that it's an NS_ERROR_UNEXPECTED to get the value of a pref that doesn't exist. That means that every single time we hit http://mxr.mozilla.org/mozilla-central/source/modules/plugin/base/src/nsPluginHost.cpp?mark=310,316#304 during mochitest-4 or mochitest-chrome (or any others I haven't noticed, that also load plugins), we spam the log multiple times with the unexciting fact that "WARNING: Unable to retrieve pref: plugins.unloadASAP: file /builds/slave/tryserver-linux-debug/build/modules/plugin/base/src/nsPluginHost.cpp, line 316," not because the pref service is broken or anything bad or out of the ordinary has happened, but just because we disagree with the prefs service about the unexpected nature of getting a value for a pref that doesn't exist.

Comment 1

[Josh Aas]

Comment on attachment 487186 [details] [diff] [review]
Fix

I've had this exact patch sitting around for a couple of weeks, waiting for a chance to slip it into another patch. r+, approval2.0+

Comment 2

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/f07a66e227ec