608549 - "ABORT: Negative sample time for active animation"

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase (asserts fatally when loaded)

###!!! ABORT: Negative sample time for active animation: 'mSampleTime >= 0 || !mIsActive', file content/smil/nsSMILAnimationFunction.cpp, line 244

Comment 1

[Brian Birtles (:birtles)]

Attachment: Patch v1a

Proposed fix. Adds range checks for calls to begin/endElement.

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 488408 [details] [diff] [review]
Patch v1a

Nit: Could you tweak the test so it checks both beginElementAt and endElementAt?

Perhaps like this:

  try {
    set.beginElementAt(NaN);
    return;
  } catch (e) {}
  try {
    set.endElementAt(NaN);
    return;
  } catch (e) {}

  // if we got here, we threw exceptions and skipped both early-returns,
  // as expected.
  document.documentElement.removeAttribute("class");

r=dholbert with that change.

Comment 4

[Brian Birtles (:birtles)]

Pushed: http://hg.mozilla.org/mozilla-central/rev/a0976b5560af