Closed Bug 608555 Opened 10 years ago Closed 10 years ago

Specify private browsing and addons menu icons under linux

Categories

(Firefox :: Theme, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0b10
Tracking Status
status2.0 --- ?

People

(Reporter: wgianopoulos, Assigned: wgianopoulos)

References

Details

Attachments

(4 files, 1 obsolete file)

When i developed the patch for bug 585370, KI only defined application menu icons for menuitems that had defined icons for the classic menu in gnomestripe.

I realized today that the private browsing and addons items do not have icons although they do under windows. At the time I did not realize that there already were gnomestripe icons defined for these items, but it turns out hat there are because they are user on the corresponding about: pages as the favicon.
Target Milestone: --- → Firefox 4.0b8
Attached patch patch v1 (obsolete) — Splinter Review
Attachment #487198 - Flags: review?(dao)
Screenshot showing applications menu open with tooltip with patches for bug 585370, bug 604650 and bug 608555 applied.
Attachment #487203 - Flags: ui-review?(faaborg)
As above, but with gnome menu icons disabled.
Attachment #487205 - Flags: ui-review?(faaborg)
Attachment #487203 - Flags: ui-review?(faaborg) → ui-review+
Attachment #487205 - Flags: ui-review?(faaborg) → ui-review+
Comment on attachment 487198 [details] [diff] [review]
patch v1

Seems like these icons should be added to the menu bar items as well.
Attachment #487198 - Flags: review?(dao) → review-
(In reply to comment #4)
> Comment on attachment 487198 [details] [diff] [review]
> patch v1
> 
> Seems like these icons should be added to the menu bar items as well.

OK.  I will do a new patch and ask for a ui-review first.
Attached patch patch v2Splinter Review
Dão, I think correctly, pointed out that these icons should probably be defined for the "classic" menu as well.  This patch accomplishes that.

New screenshot forthcoming.
Attachment #487198 - Attachment is obsolete: true
Attachment #493535 - Flags: ui-review?(faaborg)
Attachment #493536 - Flags: ui-review?(faaborg)
Blocks: 572482
Comment on attachment 493536 [details]
screenshot of "classic" menu with these icons

ui-r+ in that this fixes the issue the bug is mentioning (icons for add-ons and private browsing).  However, only these items should have icons.  So for instance downloads, error console, and clear recent history shouldn't be using icons.  More details in bug 611570
Attachment #493536 - Flags: ui-review?(faaborg) → ui-review+
Attachment #493535 - Flags: review?(dao)
Attachment #493535 - Flags: ui-review?(faaborg)
Attachment #493535 - Flags: review?(dao)
Attachment #493535 - Flags: review+
Comment on attachment 493535 [details] [diff] [review]
patch v2

This is a really low risk patch.  It merely defines icons for menu items in the gnomestripe theme.
Attachment #493535 - Flags: approval2.0?
status2.0: --- → ?
Re-targeting.
Target Milestone: Firefox 4.0b8 → Firefox 4.0b9
Comment on attachment 493535 [details] [diff] [review]
patch v2

a=beltzner
Attachment #493535 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/f2bd9f6873c3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 4.0b9 → Firefox 4.0b10
You need to log in before you can comment on or make changes to this bug.