608555 - Specify private browsing and addons menu icons under linux

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Bill Gianopoulos [:WG9s]]

When i developed the patch for bug 585370, KI only defined application menu icons for menuitems that had defined icons for the classic menu in gnomestripe.

I realized today that the private browsing and addons items do not have icons although they do under windows. At the time I did not realize that there already were gnomestripe icons defined for these items, but it turns out hat there are because they are user on the corresponding about: pages as the favicon.

Comment 1

[Bill Gianopoulos [:WG9s]]

Attachment: patch v1

Comment 2

[Bill Gianopoulos [:WG9s]]

Attachment: screenshot w/ gnome icons enabled

Screenshot showing applications menu open with tooltip with patches for bug 585370, bug 604650 and bug 608555 applied.

Comment 3

[Bill Gianopoulos [:WG9s]]

Attachment: screenshot w/ gnome icons disabled

As above, but with gnome menu icons disabled.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 487198 [details] [diff] [review]
patch v1

Seems like these icons should be added to the menu bar items as well.

Comment 5

[Bill Gianopoulos [:WG9s]]

(In reply to comment #4)
> Comment on attachment 487198 [details] [diff] [review]
> patch v1
> 
> Seems like these icons should be added to the menu bar items as well.

OK.  I will do a new patch and ask for a ui-review first.

Comment 6

[Bill Gianopoulos [:WG9s]]

Attachment: patch v2

Dão, I think correctly, pointed out that these icons should probably be defined for the "classic" menu as well.  This patch accomplishes that.

New screenshot forthcoming.

Comment 7

[Bill Gianopoulos [:WG9s]]

Attachment: screenshot of "classic" menu with these icons

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 493536 [details]
screenshot of "classic" menu with these icons

ui-r+ in that this fixes the issue the bug is mentioning (icons for add-ons and private browsing).  However, only these items should have icons.  So for instance downloads, error console, and clear recent history shouldn't be using icons.  More details in bug 611570

Comment 9

[Bill Gianopoulos [:WG9s]]

Comment on attachment 493535 [details] [diff] [review]
patch v2

This is a really low risk patch.  It merely defines icons for menu items in the gnomestripe theme.

Comment 10

[Bill Gianopoulos [:WG9s]]

Re-targeting.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 493535 [details] [diff] [review]
patch v2

a=beltzner

Comment 12

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/f2bd9f6873c3