If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Specify private browsing and addons menu icons under linux

RESOLVED FIXED in Firefox 4.0b10

Status

()

Firefox
Theme
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: WG9s, Assigned: WG9s)

Tracking

Trunk
Firefox 4.0b10
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(status2.0 ?)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
When i developed the patch for bug 585370, KI only defined application menu icons for menuitems that had defined icons for the classic menu in gnomestripe.

I realized today that the private browsing and addons items do not have icons although they do under windows. At the time I did not realize that there already were gnomestripe icons defined for these items, but it turns out hat there are because they are user on the corresponding about: pages as the favicon.
(Assignee)

Updated

7 years ago
Target Milestone: --- → Firefox 4.0b8
(Assignee)

Comment 1

7 years ago
Created attachment 487198 [details] [diff] [review]
patch v1
(Assignee)

Updated

7 years ago
Attachment #487198 - Flags: review?(dao)
(Assignee)

Comment 2

7 years ago
Created attachment 487203 [details]
screenshot w/ gnome icons enabled

Screenshot showing applications menu open with tooltip with patches for bug 585370, bug 604650 and bug 608555 applied.
Attachment #487203 - Flags: ui-review?(faaborg)
(Assignee)

Comment 3

7 years ago
Created attachment 487205 [details]
screenshot w/ gnome icons disabled

As above, but with gnome menu icons disabled.
(Assignee)

Updated

7 years ago
Attachment #487205 - Flags: ui-review?(faaborg)
Attachment #487203 - Flags: ui-review?(faaborg) → ui-review+
Attachment #487205 - Flags: ui-review?(faaborg) → ui-review+
Comment on attachment 487198 [details] [diff] [review]
patch v1

Seems like these icons should be added to the menu bar items as well.
Attachment #487198 - Flags: review?(dao) → review-
(Assignee)

Comment 5

7 years ago
(In reply to comment #4)
> Comment on attachment 487198 [details] [diff] [review]
> patch v1
> 
> Seems like these icons should be added to the menu bar items as well.

OK.  I will do a new patch and ask for a ui-review first.
(Assignee)

Comment 6

7 years ago
Created attachment 493535 [details] [diff] [review]
patch v2

Dão, I think correctly, pointed out that these icons should probably be defined for the "classic" menu as well.  This patch accomplishes that.

New screenshot forthcoming.
Attachment #487198 - Attachment is obsolete: true
Attachment #493535 - Flags: ui-review?(faaborg)
(Assignee)

Comment 7

7 years ago
Created attachment 493536 [details]
screenshot of "classic" menu with these icons
Attachment #493536 - Flags: ui-review?(faaborg)
(Assignee)

Updated

7 years ago
Blocks: 572482
Comment on attachment 493536 [details]
screenshot of "classic" menu with these icons

ui-r+ in that this fixes the issue the bug is mentioning (icons for add-ons and private browsing).  However, only these items should have icons.  So for instance downloads, error console, and clear recent history shouldn't be using icons.  More details in bug 611570
Attachment #493536 - Flags: ui-review?(faaborg) → ui-review+
(Assignee)

Updated

7 years ago
Attachment #493535 - Flags: review?(dao)

Updated

7 years ago
Attachment #493535 - Flags: ui-review?(faaborg)
Attachment #493535 - Flags: review?(dao)
Attachment #493535 - Flags: review+
(Assignee)

Comment 9

7 years ago
Comment on attachment 493535 [details] [diff] [review]
patch v2

This is a really low risk patch.  It merely defines icons for menu items in the gnomestripe theme.
Attachment #493535 - Flags: approval2.0?
(Assignee)

Updated

7 years ago
status2.0: --- → ?
(Assignee)

Comment 10

7 years ago
Re-targeting.
Target Milestone: Firefox 4.0b8 → Firefox 4.0b9
Comment on attachment 493535 [details] [diff] [review]
patch v2

a=beltzner
Attachment #493535 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/f2bd9f6873c3
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 4.0b9 → Firefox 4.0b10
You need to log in before you can comment on or make changes to this bug.