Closed
Bug 608627
Opened 15 years ago
Closed 15 years ago
Drop jsWorkspaceTitle from headsUpDisplay.properties
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | - |
People
(Reporter: rimas, Assigned: rcampbell)
References
()
Details
(Whiteboard: [string-removals][approved-to-land-post-b7])
Attachments
(1 file)
|
754 bytes,
patch
|
mossop
:
review+
mossop
:
approval2.0+
|
Details | Diff | Splinter Review |
MXR (see the URL field) shows that the jsWorkspaceTitle string defined in headsUpDisplay.properties is not actually used anywhere. Can we maybe just drop it?
|
Assignee | |
Comment 1•15 years ago
|
||
Hi!
This is for a feature that hasn't been implemented yet. Probably safe to remove, but would be great to have in case we create the feature later on.
|
|
Assignee | |
Comment 2•15 years ago
|
||
after further discussion, it's unlikely we'll get this in for Fx4 so it's safe to remove.
|
|
Assignee | |
Comment 3•15 years ago
|
||
not sure if string removal qualifies for blocking status, but marking it here to get it noticed.
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
blocking2.0: --- → ?
Whiteboard: [strings]
|
|
||
Comment 4•15 years ago
|
||
Not really strings, let's tweak the whiteboard to signal that removing strings is a good thing.
Whiteboard: [strings] → [string-removals]
|
|
Assignee | |
Comment 5•15 years ago
|
||
Attachment #487900 -
Flags: review?(dtownsend)
|
||
Comment 6•15 years ago
|
||
Comment on attachment 487900 [details] [diff] [review]
[checked-in] string-removal
Approved to land post-b7
Attachment #487900 -
Flags: review?(dtownsend)
Attachment #487900 -
Flags: review+
Attachment #487900 -
Flags: approval2.0+
|
|
||
Updated•15 years ago
|
blocking2.0: ? → -
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [string-removals] → [string-removals][approved-to-land-post-b7]
|
|
Assignee | |
Comment 7•15 years ago
|
||
Comment on attachment 487900 [details] [diff] [review]
[checked-in] string-removal
http://hg.mozilla.org/mozilla-central/rev/04a2ce3c9d2f
Attachment #487900 -
Attachment description: string-removal → [checked-in] string-removal
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•