608630 - Media element's simple events shouldn't bubble

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Our media element events are bubbling. They shouldn't be. 

Whenever the WHATWG spec talks about "firing a simple event named 'e'", it links to http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#fire-a-simple-event, which says: 

"Firing a simple event named e means that an event with the name e, which does not bubble (except where otherwise stated) and is not cancelable (except where otherwise stated), and which uses the Event interface, must be dispatched at the given target."

So we should not bubble when firing simple events on the media element. I note that Chrome and Opera aren't bubbling.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Don't bubble.

Don't bubble media events. "error" listener in video controls must capture, so it can receive "error" events dispatched to source children.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

http://hg.mozilla.org/mozilla-central/rev/4504ef280663