remote testing + browser-chrome yields missing testConfig.js file

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
9 months ago

People

(Reporter: jmaher, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobile_unittests])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Created attachment 487341 [details] [diff] [review]
copy over the profile after testConfig.js is created (1.0)

One small oversight in testing end to end browser chrome on a remote device was the testConfig.js file which contains the config parameters for browser-chrome.  This is stored in the profile directory, but created after the initial profile creation (and copy to remote device).

This patch copies the profile again after testConfig.js is created.  A simple fix.
Attachment #487341 - Flags: review?(ctalbert)
(Reporter)

Updated

8 years ago
Whiteboard: [mobile_unittests]

Comment 1

8 years ago
Comment on attachment 487341 [details] [diff] [review]
copy over the profile after testConfig.js is created (1.0)

I don't understand this.

We push the locally created profile to the remote device in buildProfile().  Why are you pushing it again from buildURLOptions?  This feels kind of hacky.  Why not just change when testConfig.js gets generated so that it is generated before the profile is pushed over?  If it is in the profile, shouldn't it be generated by "buildProfile()" in the base Mochitest class?
(Reporter)

Comment 2

8 years ago
we need the logpath to be set which is done in buildurloptions (the appropriate place).  Once that is set, we can create the browser chrome options file (testConfig.js).  

I think it is broken up logically, but we could move the log file verification and setup in buildProfile.  Th code in runtests.py.in is sort of a chicken and egg to be honest.

Comment 3

8 years ago
Comment on attachment 487341 [details] [diff] [review]
copy over the profile after testConfig.js is created (1.0)

ok, since pushDir is going to be smart and only push files that don't exist on the device this will work ok r+
Attachment #487341 - Flags: review?(ctalbert) → review+

Comment 4

8 years ago
landed on m-c http://hg.mozilla.org/mozilla-central/rev/36c2ca92e9ff
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 months ago
Component: New Frameworks → General
Product: Testing → Testing
You need to log in before you can comment on or make changes to this bug.