608911 - Invalid check in browser_bug562890.js

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

This was added by Bug 562890.

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/browser/browser_bug562890.js#62

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 487643 [details] [diff] [review]
patch rev1

found another change I'd like to make

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 487657 [details] [diff] [review]
patch rev2

>diff --git a/toolkit/mozapps/extensions/test/browser/browser_bug562890.js b/toolkit/mozapps/extensions/test/browser/browser_bug562890.js
>--- a/toolkit/mozapps/extensions/test/browser/browser_bug562890.js
>+++ b/toolkit/mozapps/extensions/test/browser/browser_bug562890.js
>@@ -5,18 +5,22 @@
> /**
>  * Tests the Preferences button for addons in list view
>  */
> 
> function test() {
>   requestLongerTimeout(2);
> 
>   waitForExplicitFinish();
>-  
>-  var addonPrefsURI = TESTROOT + "addon_prefs.xul";
>+
>+  var addonPrefPathParts = getRootDirectory(gTestPath).split("/");
>+  // Drop the test last directory name
>+  addonPrefPathParts.splice(addonPrefPathParts.length - 2);
>+  addonPrefPathParts.push("browser");
>+  var addonPrefsURI = addonPrefPathParts.join("/") + "/" + "addon_prefs.xul";

Actually you should just be able to use CHROMEROOT + "addon_prefs.xul" here.

r+ with that change.

Comment 5

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/48ae242466f0

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed by check-in.