Closed
Bug 608940
Opened 14 years ago
Closed 14 years ago
remove unused function gfxTextRun::Clone
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
Attachments
(1 file)
2.66 KB,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
Noticed while checking textrun allocation safety issues.... We have a (virtual) function Clone() on gfxTextRun, but as far as I can tell it's not used anywhere; I think we should remove it.
(If we *did* need a function to clone textruns, we should design it differently anyhow - there shouldn't be any need to pass the original text as a parameter to Clone(), as the textrun already either owns or refers to a copy.)
Attachment #487536 -
Flags: review?(jdaggett)
Updated•14 years ago
|
Attachment #487536 -
Flags: review?(jdaggett) → review+
Assignee | ||
Comment 1•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•