Last Comment Bug 608940 - remove unused function gfxTextRun::Clone
: remove unused function gfxTextRun::Clone
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Jonathan Kew (:jfkthame)
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-02 03:27 PDT by Jonathan Kew (:jfkthame)
Modified: 2011-04-27 22:15 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
remove the gfxTextRun::Clone function (2.66 KB, patch)
2010-11-02 03:27 PDT, Jonathan Kew (:jfkthame)
jd.bugzilla: review+
Details | Diff | Splinter Review

Description Jonathan Kew (:jfkthame) 2010-11-02 03:27:38 PDT
Created attachment 487536 [details] [diff] [review]
remove the gfxTextRun::Clone function

Noticed while checking textrun allocation safety issues.... We have a (virtual) function Clone() on gfxTextRun, but as far as I can tell it's not used anywhere; I think we should remove it.

(If we *did* need a function to clone textruns, we should design it differently anyhow - there shouldn't be any need to pass the original text as a parameter to Clone(), as the textrun already either owns or refers to a copy.)
Comment 1 Jonathan Kew (:jfkthame) 2011-04-27 22:15:41 PDT
http://hg.mozilla.org/mozilla-central/rev/60ea7d2f4289

Note You need to log in before you can comment on or make changes to this bug.