Closed Bug 608992 Opened 11 years ago Closed 11 years ago

Adjust l10n-compare filter to ignore additional feed readers

Categories

(SeaMonkey :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kairo, Assigned: Callek)

Details

Attachments

(1 file, 1 obsolete file)

French has one feed reader in addition, we should not rant about this. See the following message:

--------------------------------------------------------------------------
On 31.10.10 23:57, Robert Kaiser wrote:
> Benoit schrieb:
>> Is there a way to make our dashboard green for SeaMonkey as well without
>> removing any feed reader?
>
> No idea, I think we need some info from someone who does know more on
> the dashboard stuff - Axel?
>
> Robert Kaiser

You'll need to tweak filter.py, http://mxr.mozilla.org/mozilla-central/source/browser/locales/filter.py?mark=29-29

Axel 
--------------------------------------------------------------------------
Attached patch v1 (obsolete) — Splinter Review
Do it, and let locales change search.order too.

Requesting feedback from Pike as well.
Assignee: nobody → bugspam.Callek
Status: NEW → ASSIGNED
Attachment #487615 - Flags: review?(kairo)
Attachment #487615 - Flags: feedback?(l10n)
Comment on attachment 487615 [details] [diff] [review]
v1

This needs to be on source paths, not jar paths.
Attachment #487615 - Flags: feedback?(l10n) → feedback-
Attached patch v2Splinter Review
Fix paths to actually be right.
Attachment #487615 - Attachment is obsolete: true
Attachment #487625 - Flags: review?(kairo)
Attachment #487625 - Flags: feedback?(l10n)
Attachment #487615 - Flags: review?(kairo)
Comment on attachment 487625 [details] [diff] [review]
v2

Looks good to me on code inspection, but I want an r+ from Axel as well, so converting the request to be that.
Attachment #487625 - Flags: review?(l10n)
Attachment #487625 - Flags: review?(kairo)
Attachment #487625 - Flags: review+
Attachment #487625 - Flags: feedback?(l10n)
Comment on attachment 487625 [details] [diff] [review]
v2

Looks good to me.

A possible follow-up bug could be to convert from boolean return values to the string return values, "ignore" or "error" (or "report"). Same for fx, but it should make these patches easier to review.
Attachment #487625 - Flags: review?(l10n) → review+
http://hg.mozilla.org/comm-central/rev/b16d95caed01
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.