608992 - Adjust l10n-compare filter to ignore additional feed readers

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Robert Kaiser]

French has one feed reader in addition, we should not rant about this. See the following message:

--------------------------------------------------------------------------
On 31.10.10 23:57, Robert Kaiser wrote:
> Benoit schrieb:
>> Is there a way to make our dashboard green for SeaMonkey as well without
>> removing any feed reader?
>
> No idea, I think we need some info from someone who does know more on
> the dashboard stuff - Axel?
>
> Robert Kaiser

You'll need to tweak filter.py, http://mxr.mozilla.org/mozilla-central/source/browser/locales/filter.py?mark=29-29

Axel 
--------------------------------------------------------------------------

Comment 1

[Justin Wood (:Callek)]

Attachment: v1

Do it, and let locales change search.order too.

Requesting feedback from Pike as well.

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 487615 [details] [diff] [review]
v1

This needs to be on source paths, not jar paths.

Comment 3

[Justin Wood (:Callek)]

Attachment: v2

Fix paths to actually be right.

Comment 4

[Robert Kaiser]

Comment on attachment 487625 [details] [diff] [review]
v2

Looks good to me on code inspection, but I want an r+ from Axel as well, so converting the request to be that.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 487625 [details] [diff] [review]
v2

Looks good to me.

A possible follow-up bug could be to convert from boolean return values to the string return values, "ignore" or "error" (or "report"). Same for fx, but it should make these patches easier to review.

Comment 6

[Justin Wood (:Callek)]

http://hg.mozilla.org/comm-central/rev/b16d95caed01