609072 - Default favicon does not appear on about: pages

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

The "about:fennec" page does not set a custom favicon, and the default favicon does not appear either.  There is no favicon visible at all.  This seems to be an old bug; I can reproduce it in the latest trunk build and also in Fenenc 1.1.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

That's true of all the local pages on maemo.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I wrote too soon:
about:home, about:firstrun does have favicon

about:fennec, about:firefox, about:config, about:rights, about:, etc. do no t seem to.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This brings us closer to the logic in desktop Firefox.  Just like desktop, shouldLoadFavicon is now used only to decide whether to load the default "/favicon.ico" patch, and returns true only for HTTP and HTTPS documents.

Also like desktop, <link rel="icon"> is now loaded unconditionally, so the explicit favicon on about:home still works.

Comment 4

[Matt Brubeck (:mbrubeck)]

I should mention that the cause of this bug was the favicon service failing to create a channel for the URI "about:/favicon.ico".

Comment 5

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/5c7a70b65303

Comment 6

[Ioana Chiorean]

verified fixed on build id: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre)
Gecko/20110304 Firefox/4.0b13pre Fennec /4.0b6pre