Add plugin-container.exe to ShimInclusionList via installer

RESOLVED FIXED in Firefox 4.0b8

Status

()

Firefox
Installer
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: mcsmurf, Assigned: mcsmurf)

Tracking

Trunk
Firefox 4.0b8
x86
Windows XP
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
Now that Firefox trunk uses out-of-process plugins we need to add the plugin-container.exe file to the HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\MediaPlayer\ShimInclusionList registry key as otherwise WMP falls back to version 6.4.
(Assignee)

Comment 1

7 years ago
Created attachment 489241 [details] [diff] [review]
Firefox patch
[Checked in: Comment 5]
Assignee: nobody → bugzilla
Attachment #489241 - Flags: review?
(Assignee)

Updated

7 years ago
Attachment #489241 - Flags: review? → review?(robert.bugzilla)
(Assignee)

Comment 2

7 years ago
Created attachment 489242 [details] [diff] [review]
SeaMonkey Patch
[Checked in: Comment 8]
Attachment #489242 - Flags: review?(bugzilla)
Comment on attachment 489241 [details] [diff] [review]
Firefox patch
[Checked in: Comment 5]

Thanks!
Attachment #489241 - Flags: review?(robert.bugzilla) → review+
(Assignee)

Comment 4

7 years ago
Comment on attachment 489241 [details] [diff] [review]
Firefox patch
[Checked in: Comment 5]

Adds a simple registry key so that Firefox users will not get the old Windows Media Player 6.4 plugin fallback (instead they'll then get the current WMP plugin).
Attachment #489241 - Flags: approval2.0?
Attachment #489241 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 5

7 years ago
Comment on attachment 489241 [details] [diff] [review]
Firefox patch
[Checked in: Comment 5]

Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/07f583c6cc07
Comment on attachment 489242 [details] [diff] [review]
SeaMonkey Patch
[Checked in: Comment 8]

rs=Standard8 by inspection. I've not tested this.
Attachment #489242 - Flags: review?(bugzilla) → review+
Frank, ping... looks like the SeaMonkey patch never landed.
Attachment #489241 - Attachment description: Firefox patch → Firefox patch [Checked in: Comment 5]
Comment on attachment 489242 [details] [diff] [review]
SeaMonkey Patch
[Checked in: Comment 8]

http://hg.mozilla.org/comm-central/rev/0d0b82e294d2
Attachment #489242 - Attachment description: SeaMonkey Patch → SeaMonkey Patch [Checked in: Comment 8]
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
(Assignee)

Comment 9

6 years ago
Well, uh, thanks for that, but can I check-in my patches myself? Someone already reminded me of that patch today.
(In reply to comment #9)
> can I check-in my patches myself?

Sure: I just (wrongly) assumed "SeaMonkey Patch Needs landing" on SM Status Meeting and no reply here for 2.5 months meant "checkin-needed" :-/
You need to log in before you can comment on or make changes to this bug.