Closed
Bug 609106
Opened 14 years ago
Closed 14 years ago
Add plugin-container.exe to ShimInclusionList via installer
Categories
(Firefox :: Installer, defect)
Tracking
()
RESOLVED
FIXED
Firefox 4.0b8
People
(Reporter: mcsmurf, Assigned: mcsmurf)
Details
Attachments
(2 files)
|
1.31 KB,
patch
|
robert.strong.bugs
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
|
1.19 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
Now that Firefox trunk uses out-of-process plugins we need to add the plugin-container.exe file to the HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\MediaPlayer\ShimInclusionList registry key as otherwise WMP falls back to version 6.4.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → bugzilla
Attachment #489241 -
Flags: review?
|
|
Assignee | |
Updated•14 years ago
|
Attachment #489241 -
Flags: review? → review?(robert.bugzilla)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #489242 -
Flags: review?(bugzilla)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 489241 [details] [diff] [review]
Firefox patch
[Checked in: Comment 5]
Thanks!
Attachment #489241 -
Flags: review?(robert.bugzilla) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 489241 [details] [diff] [review]
Firefox patch
[Checked in: Comment 5]
Adds a simple registry key so that Firefox users will not get the old Windows Media Player 6.4 plugin fallback (instead they'll then get the current WMP plugin).
Attachment #489241 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #489241 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Comment on attachment 489241 [details] [diff] [review]
Firefox patch
[Checked in: Comment 5]
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/07f583c6cc07
|
||
Comment 6•14 years ago
|
||
Comment on attachment 489242 [details] [diff] [review]
SeaMonkey Patch
[Checked in: Comment 8]
rs=Standard8 by inspection. I've not tested this.
Attachment #489242 -
Flags: review?(bugzilla) → review+
|
|
||
Comment 7•14 years ago
|
||
Frank, ping... looks like the SeaMonkey patch never landed.
|
||
Updated•14 years ago
|
Attachment #489241 -
Attachment description: Firefox patch → Firefox patch
[Checked in: Comment 5]
|
|
||
Comment 8•14 years ago
|
||
Comment on attachment 489242 [details] [diff] [review]
SeaMonkey Patch
[Checked in: Comment 8]
http://hg.mozilla.org/comm-central/rev/0d0b82e294d2
Attachment #489242 -
Attachment description: SeaMonkey Patch → SeaMonkey Patch
[Checked in: Comment 8]
|
|
||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
|
|
Assignee | |
Comment 9•14 years ago
|
||
Well, uh, thanks for that, but can I check-in my patches myself? Someone already reminded me of that patch today.
|
|
||
Comment 10•14 years ago
|
||
(In reply to comment #9)
> can I check-in my patches myself?
Sure: I just (wrongly) assumed "SeaMonkey Patch Needs landing" on SM Status Meeting and no reply here for 2.5 months meant "checkin-needed" :-/
You need to log in
before you can comment on or make changes to this bug.
Description
•