Closed Bug 609107 Opened 11 years ago Closed 9 years ago

[Windows] Update dropmarkers for main window.

Categories

(Firefox :: Theme, defect)

All
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 13

People

(Reporter: tymerkaev, Assigned: tymerkaev)

Details

Attachments

(1 file, 4 obsolete files)

No description provided.
Attached patch patch (obsolete) — Splinter Review
Attachment #487969 - Flags: review?(dao)
Attachment #487969 - Attachment is obsolete: true
Attachment #487969 - Flags: review?(dao)
Attached patch patch v2 (obsolete) — Splinter Review
Attachment #487981 - Flags: review?(dao)
Comment on attachment 487981 [details] [diff] [review]
patch v2

>-.toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker,
> toolbar[iconsize="small"][mode="icons"] .toolbarbutton-1 > .toolbarbutton-menubutton-button,
> toolbar[iconsize="small"][mode="icons"] .toolbarbutton-1 {
>   padding-left: 3px;
>   padding-right: 3px;
> }
> 
>+.toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker,
>+.toolbarbutton-1 > .toolbarbutton-menu-dropmarker {
>+  list-style-image: url("chrome://browser/skin/dropdown-arrow.png");
>+  -moz-image-region: rect(0, 11px, 9px, 0);
>+  padding: 2px;
>+}
>+
>+.toolbarbutton-1 > .toolbarbutton-menu-dropmarker {
>+  -moz-padding-end: 0;
>+  margin: 0;
>+}

This appears to be making menu buttons much wider. That is, wider than they are in the mockups.

> .urlbar-history-dropmarker {
>   -moz-appearance: none;
>-  padding: 0 1px;
>+  padding: 2px;
>   background-color: transparent;
>   border: none;
>   width: auto;
>-  list-style-image: url(mainwindow-dropdown-arrow.png);
>-  -moz-image-region: rect(0, 13px, 11px, 0);
>+  list-style-image: url("chrome://browser/skin/dropdown-arrow.png");
>+  -moz-image-region: rect(0, 11px, 9px, 0);
> }
> 
> .urlbar-history-dropmarker:-moz-system-metric(touch-enabled) {
>@@ -1154,7 +1165,7 @@ html|*.urlbar-input:-moz-lwtheme:-moz-pl
> 
> .urlbar-history-dropmarker:hover:active,
> .urlbar-history-dropmarker[open="true"] {
>-  -moz-image-region: rect(0, 26px, 11px, 13px);
>+  -moz-image-region: rect(0, 22px, 9px, 11px);
> }

Can you avoid this and focus on toolbarbuttons in this bug?

>--- a/toolkit/themes/winstripe/global/toolbarbutton.css
>+++ b/toolkit/themes/winstripe/global/toolbarbutton.css
>@@ -147,10 +147,6 @@ toolbarbutton[checked="true"]:not([disab
>   margin-top: 1px;
> }
> 
>-.toolbarbutton-menu-dropmarker[disabled="true"] {
>-  padding: 0 !important;
>-}

What's the story here about? Why can this be removed without some replacement?
Attachment #487981 - Flags: review?(dao) → review-
Assignee: nobody → tymerkaev
Attachment #487981 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Summary: [Windows] Update menu and menubutton dropmarker for .toolbarbutton-1. → [Windows] Update dropmarkers for main window.
Attached patch patch v3 (obsolete) — Splinter Review
(In reply to comment #3)
> >-.toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker,
> > toolbar[iconsize="small"][mode="icons"] .toolbarbutton-1 > .toolbarbutton-menubutton-button,
> > toolbar[iconsize="small"][mode="icons"] .toolbarbutton-1 {
> >   padding-left: 3px;
> >   padding-right: 3px;
> > }
> > 
> >+.toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker,
> >+.toolbarbutton-1 > .toolbarbutton-menu-dropmarker {
> >+  list-style-image: url("chrome://browser/skin/dropdown-arrow.png");
> >+  -moz-image-region: rect(0, 11px, 9px, 0);
> >+  padding: 2px;
> >+}
> >+
> >+.toolbarbutton-1 > .toolbarbutton-menu-dropmarker {
> >+  -moz-padding-end: 0;
> >+  margin: 0;
> >+}
> 
> This appears to be making menu buttons much wider. That is, wider than they are in the mockups.

Fixed by removing extra glow from dropmarker itself.
> > .urlbar-history-dropmarker {
> >   -moz-appearance: none;
> >-  padding: 0 1px;
> >+  padding: 2px;
> >   background-color: transparent;
> >   border: none;
> >   width: auto;
> >-  list-style-image: url(mainwindow-dropdown-arrow.png);
> >-  -moz-image-region: rect(0, 13px, 11px, 0);
> >+  list-style-image: url("chrome://browser/skin/dropdown-arrow.png");
> >+  -moz-image-region: rect(0, 11px, 9px, 0);
> > }
> > 
> > .urlbar-history-dropmarker:-moz-system-metric(touch-enabled) {
> >@@ -1154,7 +1165,7 @@ html|*.urlbar-input:-moz-lwtheme:-moz-pl
> > 
> > .urlbar-history-dropmarker:hover:active,
> > .urlbar-history-dropmarker[open="true"] {
> >-  -moz-image-region: rect(0, 26px, 11px, 13px);
> >+  -moz-image-region: rect(0, 22px, 9px, 11px);
> > }
> 
> Can you avoid this and focus on toolbarbuttons in this bug?

No, .urlbar-history-dropmarker using mainwindow-dropdown-arrow.png, which should be replaced by new image.
> >-.toolbarbutton-menu-dropmarker[disabled="true"] {
> >-  padding: 0 !important;
> >-}
> 
> What's the story here about? Why can this be removed without some replacement?

Same as for http://hg.mozilla.org/mozilla-central/diff/a05ab26714f6/toolkit/themes/winstripe/global/toolbarbutton.css.
Attachment #488647 - Flags: review?(dao)
Attachment #488647 - Flags: feedback?(shorlander)
Comment on attachment 488647 [details] [diff] [review]
patch v3

Using the new image for the location bar was neither planned nor does it look better, imho (feels heavier). Just avoid that change and name the new file toolbarbutton-dropdown-arrow.png.
Attachment #488647 - Flags: review?(dao) → review-
Does this also effect the dropdown marker in the bookmarks toolbar button?
(In reply to comment #6)
> Does this also effect the dropdown marker in the bookmarks toolbar button?

Yes.
Attached patch patch v4 (obsolete) — Splinter Review
Attachment #488647 - Attachment is obsolete: true
Attachment #515058 - Flags: review?(dao)
Attachment #488647 - Flags: feedback?(shorlander)
Is there something still holding this bug back? Just wondering what else needs to be done.
Kurt, you can almost always answer these kinds of questions for yourself (like your question in bug 618353) If you look at the patch, you'll see that it's awaiting a review from Dão. 

It's a safe bet that Dão has not forgotten about this bug but he's got a rather large set of responsibilities. He has a good track record of prioritizing them well so I don't think that there's much value in "are we there yet" comments or other "pokes".
Attached patch updated patchSplinter Review
Updated to tip, renamed a few files, removed a few changes not needed for this bug (e.g. the menu-vertical binding and the change to the search engine button's dropmarker). Patch is good to go with these modifications.
Attachment #515058 - Attachment is obsolete: true
Attachment #595759 - Flags: review+
Attachment #515058 - Flags: review?(dao)
https://hg.mozilla.org/mozilla-central/rev/401146857eb9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Is this fixed completely? On nightly, noticed the dropdown arrow for Add-ons Manager section next to the wrench icon still has the old dropdown arrow.
You need to log in before you can comment on or make changes to this bug.