The default bug view has changed. See this FAQ.

[Windows] Update dropmarkers for main window.

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Theme
RESOLVED FIXED
7 years ago
3 years ago

People

(Reporter: tymerkaev, Assigned: tymerkaev)

Tracking

Trunk
Firefox 13
All
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

7 years ago
Created attachment 487969 [details] [diff] [review]
patch
Attachment #487969 - Flags: review?(dao)
(Assignee)

Updated

7 years ago
Attachment #487969 - Attachment is obsolete: true
Attachment #487969 - Flags: review?(dao)
(Assignee)

Comment 2

7 years ago
Created attachment 487981 [details] [diff] [review]
patch v2
Attachment #487981 - Flags: review?(dao)
Comment on attachment 487981 [details] [diff] [review]
patch v2

>-.toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker,
> toolbar[iconsize="small"][mode="icons"] .toolbarbutton-1 > .toolbarbutton-menubutton-button,
> toolbar[iconsize="small"][mode="icons"] .toolbarbutton-1 {
>   padding-left: 3px;
>   padding-right: 3px;
> }
> 
>+.toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker,
>+.toolbarbutton-1 > .toolbarbutton-menu-dropmarker {
>+  list-style-image: url("chrome://browser/skin/dropdown-arrow.png");
>+  -moz-image-region: rect(0, 11px, 9px, 0);
>+  padding: 2px;
>+}
>+
>+.toolbarbutton-1 > .toolbarbutton-menu-dropmarker {
>+  -moz-padding-end: 0;
>+  margin: 0;
>+}

This appears to be making menu buttons much wider. That is, wider than they are in the mockups.

> .urlbar-history-dropmarker {
>   -moz-appearance: none;
>-  padding: 0 1px;
>+  padding: 2px;
>   background-color: transparent;
>   border: none;
>   width: auto;
>-  list-style-image: url(mainwindow-dropdown-arrow.png);
>-  -moz-image-region: rect(0, 13px, 11px, 0);
>+  list-style-image: url("chrome://browser/skin/dropdown-arrow.png");
>+  -moz-image-region: rect(0, 11px, 9px, 0);
> }
> 
> .urlbar-history-dropmarker:-moz-system-metric(touch-enabled) {
>@@ -1154,7 +1165,7 @@ html|*.urlbar-input:-moz-lwtheme:-moz-pl
> 
> .urlbar-history-dropmarker:hover:active,
> .urlbar-history-dropmarker[open="true"] {
>-  -moz-image-region: rect(0, 26px, 11px, 13px);
>+  -moz-image-region: rect(0, 22px, 9px, 11px);
> }

Can you avoid this and focus on toolbarbuttons in this bug?

>--- a/toolkit/themes/winstripe/global/toolbarbutton.css
>+++ b/toolkit/themes/winstripe/global/toolbarbutton.css
>@@ -147,10 +147,6 @@ toolbarbutton[checked="true"]:not([disab
>   margin-top: 1px;
> }
> 
>-.toolbarbutton-menu-dropmarker[disabled="true"] {
>-  padding: 0 !important;
>-}

What's the story here about? Why can this be removed without some replacement?
Attachment #487981 - Flags: review?(dao) → review-

Updated

7 years ago
Assignee: nobody → tymerkaev
(Assignee)

Updated

7 years ago
Attachment #487981 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

7 years ago
Summary: [Windows] Update menu and menubutton dropmarker for .toolbarbutton-1. → [Windows] Update dropmarkers for main window.
(Assignee)

Comment 4

7 years ago
Created attachment 488647 [details] [diff] [review]
patch v3

(In reply to comment #3)
> >-.toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker,
> > toolbar[iconsize="small"][mode="icons"] .toolbarbutton-1 > .toolbarbutton-menubutton-button,
> > toolbar[iconsize="small"][mode="icons"] .toolbarbutton-1 {
> >   padding-left: 3px;
> >   padding-right: 3px;
> > }
> > 
> >+.toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker,
> >+.toolbarbutton-1 > .toolbarbutton-menu-dropmarker {
> >+  list-style-image: url("chrome://browser/skin/dropdown-arrow.png");
> >+  -moz-image-region: rect(0, 11px, 9px, 0);
> >+  padding: 2px;
> >+}
> >+
> >+.toolbarbutton-1 > .toolbarbutton-menu-dropmarker {
> >+  -moz-padding-end: 0;
> >+  margin: 0;
> >+}
> 
> This appears to be making menu buttons much wider. That is, wider than they are in the mockups.

Fixed by removing extra glow from dropmarker itself.
> > .urlbar-history-dropmarker {
> >   -moz-appearance: none;
> >-  padding: 0 1px;
> >+  padding: 2px;
> >   background-color: transparent;
> >   border: none;
> >   width: auto;
> >-  list-style-image: url(mainwindow-dropdown-arrow.png);
> >-  -moz-image-region: rect(0, 13px, 11px, 0);
> >+  list-style-image: url("chrome://browser/skin/dropdown-arrow.png");
> >+  -moz-image-region: rect(0, 11px, 9px, 0);
> > }
> > 
> > .urlbar-history-dropmarker:-moz-system-metric(touch-enabled) {
> >@@ -1154,7 +1165,7 @@ html|*.urlbar-input:-moz-lwtheme:-moz-pl
> > 
> > .urlbar-history-dropmarker:hover:active,
> > .urlbar-history-dropmarker[open="true"] {
> >-  -moz-image-region: rect(0, 26px, 11px, 13px);
> >+  -moz-image-region: rect(0, 22px, 9px, 11px);
> > }
> 
> Can you avoid this and focus on toolbarbuttons in this bug?

No, .urlbar-history-dropmarker using mainwindow-dropdown-arrow.png, which should be replaced by new image.
> >-.toolbarbutton-menu-dropmarker[disabled="true"] {
> >-  padding: 0 !important;
> >-}
> 
> What's the story here about? Why can this be removed without some replacement?

Same as for http://hg.mozilla.org/mozilla-central/diff/a05ab26714f6/toolkit/themes/winstripe/global/toolbarbutton.css.
Attachment #488647 - Flags: review?(dao)
Attachment #488647 - Flags: feedback?(shorlander)
Comment on attachment 488647 [details] [diff] [review]
patch v3

Using the new image for the location bar was neither planned nor does it look better, imho (feels heavier). Just avoid that change and name the new file toolbarbutton-dropdown-arrow.png.
Attachment #488647 - Flags: review?(dao) → review-

Comment 6

6 years ago
Does this also effect the dropdown marker in the bookmarks toolbar button?
(In reply to comment #6)
> Does this also effect the dropdown marker in the bookmarks toolbar button?

Yes.
(Assignee)

Comment 8

6 years ago
Created attachment 515058 [details] [diff] [review]
patch v4
Attachment #488647 - Attachment is obsolete: true
Attachment #515058 - Flags: review?(dao)
Attachment #488647 - Flags: feedback?(shorlander)

Comment 9

6 years ago
Is there something still holding this bug back? Just wondering what else needs to be done.

Comment 10

6 years ago
Kurt, you can almost always answer these kinds of questions for yourself (like your question in bug 618353) If you look at the patch, you'll see that it's awaiting a review from Dão. 

It's a safe bet that Dão has not forgotten about this bug but he's got a rather large set of responsibilities. He has a good track record of prioritizing them well so I don't think that there's much value in "are we there yet" comments or other "pokes".
Created attachment 595759 [details] [diff] [review]
updated patch

Updated to tip, renamed a few files, removed a few changes not needed for this bug (e.g. the menu-vertical binding and the change to the search engine button's dropmarker). Patch is good to go with these modifications.
Attachment #515058 - Attachment is obsolete: true
Attachment #595759 - Flags: review+
Attachment #515058 - Flags: review?(dao)
http://hg.mozilla.org/integration/mozilla-inbound/rev/401146857eb9
Target Milestone: --- → Firefox 13
https://hg.mozilla.org/mozilla-central/rev/401146857eb9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 14

5 years ago
Is this fixed completely? On nightly, noticed the dropdown arrow for Add-ons Manager section next to the wrench icon still has the old dropdown arrow.
You need to log in before you can comment on or make changes to this bug.