Closed
Bug 609122
Opened 15 years ago
Closed 15 years ago
Limit the size of places.sqlite-wal
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla2.0b9
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: sdwilsh, Assigned: mak)
References
Details
(Whiteboard: [fixed-in-places])
Attachments
(1 file, 1 obsolete file)
|
2.03 KB,
patch
|
Details | Diff | Splinter Review |
Very similar to bug 608422. Need to limit how big our WAL file gets.
|
Reporter | |
Updated•15 years ago
|
blocking2.0: --- → final+
|
Assignee | |
Comment 1•15 years ago
|
||
how was the cookies wal size decided? 500KB sounds very small for places.
|
|
Reporter | |
Comment 2•15 years ago
|
||
(In reply to comment #1)
> how was the cookies wal size decided? 500KB sounds very small for places.
Oh yeah, that's too small for us. I believe dwitte just picked a reasonable size for a number of cookies.
|
|
Reporter | |
Updated•15 years ago
|
Assignee: sdwilsh → nobody
Status: ASSIGNED → NEW
|
|
Reporter | |
Updated•15 years ago
|
Whiteboard: [good first bug]
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•15 years ago
|
||
Attachment #491384 -
Flags: review?(sdwilsh)
|
|
Assignee | |
Comment 4•15 years ago
|
||
I think we don't want a test, SQLite folks must have a test for this, it's not our duty to test if their pragmas work...
Flags: in-testsuite-
Whiteboard: [good first bug]
|
|
Reporter | |
Comment 5•15 years ago
|
||
Comment on attachment 491384 [details] [diff] [review]
patch v1.0
>+ // Set the WAL journal limit. We adapt it to the device we are running on,
>+ // since mobile has not enough space for the default size.
s/has not enough/does not have/
>+ // Since our cache_size is calculated based on physical memory (a somehow good
s/somehow/somewhat/
r=sdwilsh
Attachment #491384 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Comment 6•15 years ago
|
||
Attachment #491384 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•15 years ago
|
||
Whiteboard: [fixed-in-places]
|
|
Assignee | |
Comment 8•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in
before you can comment on or make changes to this bug.
Description
•