Closed Bug 609122 Opened 14 years ago Closed 14 years ago

Limit the size of places.sqlite-wal

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b9
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: sdwilsh, Assigned: mak)

References

Details

(Whiteboard: [fixed-in-places])

Attachments

(1 file, 1 obsolete file)

patch v1.1
2.03 KB, patch
Details | Diff | Splinter Review 
Very similar to bug 608422.  Need to limit how big our WAL file gets.
blocking2.0: --- → final+
how was the cookies wal size decided? 500KB sounds very small for places.
(In reply to comment #1)
> how was the cookies wal size decided? 500KB sounds very small for places.
Oh yeah, that's too small for us.  I believe dwitte just picked a reasonable size for a number of cookies.
Assignee: sdwilsh → nobody
Status: ASSIGNED → NEW
Whiteboard: [good first bug]
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attached patch patch v1.0 (obsolete) — — Splinter Review 

        Attachment #491384 -
        Flags: review?(sdwilsh)

    
    

    
  
I think we don't want a test, SQLite folks must have a test for this, it's not our duty to test if their pragmas work...
Flags: in-testsuite-
Whiteboard: [good first bug]

    
    

    
  
Comment on attachment 491384 [details] [diff] [review]
patch v1.0

>+  // Set the WAL journal limit.  We adapt it to the device we are running on,
>+  // since mobile has not enough space for the default size.
s/has not enough/does not have/

>+  // Since our cache_size is calculated based on physical memory (a somehow good
s/somehow/somewhat/

r=sdwilsh

        Attachment #491384 -
        Flags: review?(sdwilsh) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v1.1
        — 
          — Splinter Review
      

    


  

        Attachment #491384 -
        Attachment is obsolete: true

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/6830eab89a7c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: