Closed
Bug 609162
Opened 14 years ago
Closed 14 years ago
Do not invalidate textarea at every value change (when a placeholder is set)
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: mounir, Assigned: mounir)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
1.11 KB,
patch
|
bzbarsky
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
Like bug 605741 mentioned, it's really bad for performance to invalidate textarea at every key stroke and it seems that we are currently doing that when the textarea has a placeholder attribute. This bug should be fixed with bug 605124 if it doesn't take too much time. Otherwise, I will write a patch here. It's quite simple.
|
Assignee | |
Updated•14 years ago
|
Summary: Do not invalidate textarea at every value change → Do not invalidate textarea at every value change (when a placeholder is set)
|
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #488051 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Patches in bug 605124 have to be applied on top of the patch here.
Blocks: 605124
|
||
Comment 3•14 years ago
|
||
Comment on attachment 488051 [details] [diff] [review] Patch v1 This is fine, but we should consider changing that native theme thing to check whether the states really matter before invalidating....
Attachment #488051 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #488051 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #488051 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/a26199cd24df
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
| Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•