609165 - Crash with nsIFile.contains when passed a null file reference (Mac OS X)

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Todd Whiteman]

JS Code to reproduce this:

var file = Components.classes["@mozilla.org/file/local;1"].  
                     createInstance(Components.interfaces.nsILocalFile);  
file.initWithPath("/tmp");
file.contains(null, true); /* crashes here */

Crash report here:
http://crash-stats.mozilla.com/report/index/bp-7adcbd2f-3139-46e4-a7d5-926dd2101102

Tested on Firefox 3.6.12, Mac OS X 10.6.4

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Indeed, the old Mac nsLocalFile code didn't null check the inFile argument to contains:
http://hg.mozilla.org/releases/mozilla-1.9.2/annotate/8fe44c79dfd1/xpcom/io/nsLocalFileOSX.mm#l1084

This was fixed on trunk by bug 571193.