Mail composer should watch NS_TEXT_EVENT in subject text to update the window title

VERIFIED FIXED

Status

MailNews Core
Composition
P3
normal
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: ji, Assigned: varada)

Tracking

({intl})

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.20 KB, patch
Jean-Francois Ducarroz
: review+
Bienvenu
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

18 years ago
***Observed with linux 2000110807 build ****

On a mail composer window, when you enter something in the subject field,
usually the subject appears as the window title. But on linux build, if you have
Ja IME turned on, the Ja characters entered in the subject field won't appear in
the window title until you trun off Ja IME.

Steps to reproduce:
1. Launch Mail.
2. Open a mail composer window.
3. Turn on Ja IME and enter something in the subject field. Although you commit
the characters into the field, the window title still remains as (no subject).
Once you turn off the Ja IME, the window title will reflect the subject.

This doesn't happen on window build.

Comment 1

18 years ago
Reassign to tajima san, cc to katakai san.
Assignee: nhotta → tajima

Comment 2

18 years ago
I've verified this problem only with kinput2. With ATOK X for Linux,
I could not see this problem.

Please reassign to katakai@japan.sun.com.

Thanks.

Comment 3

18 years ago
Reassign to katakai@japan.sun.com.
Assignee: tajima → katakai

Updated

17 years ago
Keywords: intl

Comment 4

17 years ago
Mass change of QA contact to ji for the bugs filed by her.
QA Contact: momoi → ji

Comment 5

17 years ago
Moved to Mail Window Front End

In messengercompose.xul, compose window watches a keyup
event on the Subject field.

   onkeyup="SetComposeWindowTitle(event.which);"

However, this does not work in the following cases.

  NS_TEXT_EVENT
   IME sends compose text as NS_TEXT_EVENT
   without any key event.

  cut&paste
   This does not work when text is pasted on Subject field.

Message Compose dialog should be able to handle such cases.
If there is no method to watch the events in XUL spec, we
should enhance XUL to handle such event.
Assignee: katakai → sspitzer
Component: Internationalization → Mail Window Front End
QA Contact: ji → esther
Summary: Mail composer: Ja subject doesn't appear in the window title when Ja IME is on → Mail composer should watch NS_TEXT_EVENT in subject text to update the window title

Comment 6

16 years ago
->Composition

Comment 7

16 years ago
Hrm. I said, ->Composition! :-)
Assignee: sspitzer → ducarroz
Component: Mail Window Front End → Composition
QA Contact: esther → sheelar

Comment 8

16 years ago
->Varada
Assignee: ducarroz → varada
(Assignee)

Updated

16 years ago
Blocks: 154188
(Assignee)

Comment 9

16 years ago
Created attachment 90145 [details] [diff] [review]
Patch V1

changing from onkeyup to oninput to deal with cut and paste as well.
Comment on attachment 90145 [details] [diff] [review]
Patch V1

R=ducarroz
Attachment #90145 - Flags: review+

Comment 11

16 years ago
Comment on attachment 90145 [details] [diff] [review]
Patch V1

sr=bienvenu
Attachment #90145 - Flags: superreview+
(Assignee)

Comment 12

16 years ago
Marking fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Updated

16 years ago
Depends on: 147625

Comment 13

16 years ago
I've verified the fix is working fine on my local build with Japanese IME.

Comment 14

16 years ago
marking verified based on comments below.
Also that I see this working on linux rh 6.2 on 2002-09-11-05
Status: RESOLVED → VERIFIED

Comment 15

16 years ago
Note that this exposes a problem with the Undo event - if you compose a new
message and hit Ctrl+Z a few times (there should be nothing to undo, Edit/Undo
is disabled) the title changes :-(
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.