609196 - [OS/2] Revise Cairo and Thebes

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[Rich Walsh]

The attached patches provide significant improvements to the OS/2 implementations of Cairo and Thebes.  Among them are: reduction of system overhead, the virtual elimination of shared memory use by the Mozilla apps, and support for bitmap-based printing.

Comment 1

[Rich Walsh]

Attachment: revises Cairo-OS/2

This is a rewrite of cairo-os2-surface.c that adds bitmap-based printing support and provides a more generic interface for client apps.  To make the code simpler and more efficient, it eliminates non-essential features that clients can easily reimplement if needed.

This patch will be submitted to CairoGraphics.org once it has been updated to their current trunk level.

Comment 2

[Rich Walsh]

Attachment: revises Thebes-OS/2

This patch eliminates the creation of PM graphics objects in Thebes that are never used.  Doing so virtually eliminates Mozilla's use of shared memory beyond that needed to load its dlls.  It also updates various files to conform to changes in cairo_os2_surface.

Comment 3

[Peter Weilbacher]

Very nice. I doubt that I ever said so anywhere but I had thought about using cairo_image_surface after other platforms started to do that. This should be the right way. I didn't occur to me, though, that this could be the fix to the printing issue.

Where does the 360 for the DPI limit come from?

Comment 4

[Rich Walsh]

Attachment: revise Cairo-OS/2 - v2

This update adds support for DIVE when the display is in 24- or 32-bit full-color modes;  the app must request that this support be enabled.  It also greatly improves display speed for video drivers that can only handle 24-bit GPI bitmaps.

Comment 5

[Rich Walsh]

Attachment: revise Thebes-OS/2 - v2

This update supports the changes made to Cairo-OS/2.  In particular, it determines whether DIVE should be enabled for the current video driver.

Comment 6

[Rich Walsh]

Attachment: DIVE-related debugging printf()s - not for checkin

Comment 7

[Rich Walsh]

I forgot to mention that DIVE will be disabled if the app is started in SafeMode or if MOZ_NO_DIVE is found in the environment.

Comment 8

[Rich Walsh]

Attachment: revise Thebes-OS/2 - v3

this update fixes mouse pointer handling when using DIVE

Comment 9

[Rich Walsh]

Attachment: DIVE-related debugging printf()s - v2 - not for checkin

Comment 10

[Wayne Mery (:wsmwk)]

OS/2 is no longer a supported platform.