Open
Bug 609301
Opened 14 years ago
Updated 4 years ago
Clean up template code now that $comment->work_time correctly returns 0 when not set
Categories
(Bugzilla :: Bugzilla-General, defect)
Tracking
()
NEW
People
(Reporter: LpSolit, Unassigned)
References
Details
Now that $comment->work_time correctly returns 0 when not set, we can remove hacks introduced in bug/show.xml.tmpl line 77 and bug/comments.html.tmpl lines 106 and 168. [% IF user.is_timetracker && (c.work_time - 0 != 0) %] [% RETURN IF comment_text == '' AND (comment.work_time - 0) != 0 AND !user.is_timetracker %] [% IF user.is_timetracker && (comment.work_time > 0 || comment.work_time < 0) %] We just have to make sure that .work_time correctly calls the method and not the hash value directly.
Reporter | ||
Updated•13 years ago
|
Target Milestone: Bugzilla 4.2 → Bugzilla 5.0
Comment 1•13 years ago
|
||
This has no assignee, we might as well untarget it entirely.
Target Milestone: Bugzilla 5.0 → ---
Updated•11 years ago
|
Assignee: general → lhenry
Updated•11 years ago
|
Assignee: lhenry → general
Updated•10 years ago
|
Whiteboard: [Good Intro Bug] → [good first bug][lang=perl]
Comment 2•9 years ago
|
||
Dylan, can you comment as to if this bug is still relevant given the current code base? If it is and will make a good first bug, help us find some links to source code, which files might be touched and how to test/verify this. Also this bug needs a mentor!
Flags: needinfo?(dylan)
Updated•9 years ago
|
Flags: needinfo?(dylan)
Updated•7 years ago
|
Keywords: good-first-bug
Is it still possible to work on this? It would be my first contribution :)
Updated•6 years ago
|
Flags: needinfo?(jmaher) → needinfo?(dkl)
Updated•5 years ago
|
Flags: needinfo?(dylan)
Flags: needinfo?(dkl)
Comment 5•5 years ago
|
||
Hi, I am an Outreachy applicant for an internship position. Is the bug still available
Comment 6•5 years ago
|
||
Hi @James, do you know if this bug is still available?
Flags: needinfo?(james)
Comment 8•5 years ago
|
||
Removing good-first-bug
keyword because team does not have bandwidth to mentor at the moment.
Keywords: good-first-bug
Updated•4 years ago
|
Whiteboard: [good first bug][lang=perl]
You need to log in
before you can comment on or make changes to this bug.
Description
•