Open Bug 609301 Opened 14 years ago Updated 4 years ago

Clean up template code now that $comment->work_time correctly returns 0 when not set

Categories

(Bugzilla :: Bugzilla-General, defect)

defect
Not set
trivial

Tracking

()

People

(Reporter: LpSolit, Unassigned)

References

Details

Now that $comment->work_time correctly returns 0 when not set, we can remove hacks introduced in bug/show.xml.tmpl line 77 and bug/comments.html.tmpl lines 106 and 168.

 [% IF user.is_timetracker && (c.work_time - 0 != 0) %]

 [% RETURN IF comment_text == '' AND (comment.work_time - 0) != 0 AND !user.is_timetracker %]

 [% IF user.is_timetracker &&
       (comment.work_time > 0 || comment.work_time < 0) %]

We just have to make sure that .work_time correctly calls the method and not the hash value directly.
Target Milestone: Bugzilla 4.2 → Bugzilla 5.0
This has no assignee, we might as well untarget it entirely.
Target Milestone: Bugzilla 5.0 → ---
Assignee: general → lhenry
Assignee: lhenry → general
Whiteboard: [Good Intro Bug] → [good first bug][lang=perl]
Dylan, can you comment as to if this bug is still relevant given the current code base?  If it is and will make a good first bug, help us find some links to source code, which files might be touched and how to test/verify this.  Also this bug needs a mentor!
Flags: needinfo?(dylan)
No longer blocks: 1126453
Flags: needinfo?(dylan)
Is it still possible to work on this? It would be my first contribution :)
Is this bug still available?
Flags: needinfo?(jmaher)
Flags: needinfo?(dylan)
Flags: needinfo?(jmaher) → needinfo?(dkl)
Flags: needinfo?(dylan)
Flags: needinfo?(dkl)

Hi, I am an Outreachy applicant for an internship position. Is the bug still available

Hi @James, do you know if this bug is still available?

Flags: needinfo?(james)

I don't know anything about this bug, sorry.

Flags: needinfo?(james)

Removing good-first-bug keyword because team does not have bandwidth to mentor at the moment.

Keywords: good-first-bug
Whiteboard: [good first bug][lang=perl]
You need to log in before you can comment on or make changes to this bug.