609363 - Recompile operates on the wrong frames

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Robert Sayre]

Attachment: get the compartment from the script, not the context

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

I think we need one additional change to AllFramesIter to make sure we iterate all frames, not just ones associated with the dummy context.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: v2

Get rid of the earlier loop, since we can reach all JIT'd frames by scanning VMFrames.

Comment 4

[Luke Wagner [:luke]]

Comment on attachment 488054 [details] [diff] [review]
v2

>+        // Scan all frames owned by this VMFrame.
>+        JSStackFrame *stopFp = f->entryFp;
>+        JSStackFrame *fp = f->fp();
>+        while (true) {
[snip]
>+            if (stopFp == fp)
>+                break;
>+
>+            fp = fp->prev();
>+        }

Perhaps:

  JSStackFrame *end = f->entryFp->prev();
  for (JSStackFrame *fp = f->fp(); fp != end; fp = fp->prev()) {
    ...
  }
?

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/tracemonkey/rev/87364777517e

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/f7016571b472