Closed
Bug 609417
Opened 14 years ago
Closed 14 years ago
We shouldn't always call SetValueChanged when clearing the file list
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file, 2 obsolete files)
|
7.49 KB,
patch
|
smaug
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
Currently, we are setting BF_VALUE_CHANGED to true each time SetFiles() is called and ClearFiles is calling SetFiles. As a consequence, when resetting the form, BF_VALUE_CHANGED is set to true and when changing the type to or from 'file', BF_VALUE_CHANGED is set to true too which happen while parsing. IOW, <input type='file'> never has it's BF_VALUE_CHANGED sets to false which is annoying for bug 605124. Like we do for SetInternalValue, we should specify if we want SetValueChanged to be called.
Attachment #488040 -
Flags: review?(Olli.Pettay)
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #488040 -
Attachment is obsolete: true
Attachment #488044 -
Flags: review?(Olli.Pettay)
Attachment #488040 -
Flags: review?(Olli.Pettay)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #488044 -
Attachment is obsolete: true
Attachment #488049 -
Flags: review?(Olli.Pettay)
Attachment #488044 -
Flags: review?(Olli.Pettay)
|
||
Updated•14 years ago
|
Attachment #488049 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #488049 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #488049 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/023f675df2a0
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•