Closed
Bug 609418
Opened 15 years ago
Closed 15 years ago
double vs const double for nsGeoPositionCoords::nsGeoPositionCoords(...)
Categories
(Core :: DOM: Geolocation, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
Details
Attachments
(1 file)
1.06 KB,
patch
|
dougt
:
review+
dougt
:
approval2.0+
|
Details | Diff | Splinter Review |
The mismatch between nsGeoPosition.cpp and nsGeoPosition.h caused a linking problem on Solaris. (with IPC enabled)
We can change nsGeoPosition.h or nsGeoPosition.cpp.
Since nsGeoPosition::nsGeoPosition is using double in nsGeoPosition.h.
I decided to change nsGeoPosition.h.
Attachment #488048 -
Flags: review?(doug.turner)
Comment 2•15 years ago
|
||
Comment on attachment 488048 [details] [diff] [review]
patch
low risk.
Ginn, thank you for the fix. Be sure that this passes try before pushing to m-c.
Attachment #488048 -
Flags: review?(doug.turner)
Attachment #488048 -
Flags: review+
Attachment #488048 -
Flags: approval2.0+
Updated•15 years ago
|
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•