Closed Bug 609418 Opened 9 years ago Closed 9 years ago

double vs const double for nsGeoPositionCoords::nsGeoPositionCoords(...)

Categories

(Core :: DOM: Geolocation, defect)

x86
Solaris
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Details

Attachments

(1 file)

The mismatch between nsGeoPosition.cpp and nsGeoPosition.h caused a linking problem on Solaris. (with IPC enabled)
Attached patch patchSplinter Review
We can change nsGeoPosition.h or nsGeoPosition.cpp.
Since nsGeoPosition::nsGeoPosition is using double in nsGeoPosition.h.
I decided to change nsGeoPosition.h.
Attachment #488048 - Flags: review?(doug.turner)
Comment on attachment 488048 [details] [diff] [review]
patch

low risk.

Ginn, thank you for the fix.  Be sure that this passes try before pushing to m-c.
Attachment #488048 - Flags: review?(doug.turner)
Attachment #488048 - Flags: review+
Attachment #488048 - Flags: approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/2951546c734a
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.