Insert and Format entries in menubar in MailNews Compose window enable on hover

RESOLVED FIXED in mozilla2.0b8

Status

()

Toolkit
Themes
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
mozilla2.0b8
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
In classic theme, the Insert and Format entries in the MailNews Compose window are disabled when the focus is not in the message body part of the window, but when you hover over the entries they become enabled (but not usable).
Steps to reproduce:
1/ Open a compose window
2/ Click into the address widget
3/ Note the Insert and Format entries in the menubar are greyed out
4/ Hover over either of the entries

Actual result:
1/ Entries no longer greyed out

Expected result:
1/ Entries stay greyed out
(Assignee)

Comment 1

7 years ago
Looks like this is from:
/mozilla/toolkit/themes/gnomestripe/global/menu.css

menu[disabled="true"],
menuitem[disabled="true"] {
  color: GrayText;
}
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/themes/gnomestripe/global/menu.css#70

Comes before:

menubar > menu[_moz-menuactive="true"] {
  color: -moz-menubartext;
}
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/themes/gnomestripe/global/menu.css#89

which means it no longer shows as disabled.

For winstripe and pinstripe :not([disabled="true"]) is used to stop it having an effect (and on the -moz-lwtheme entry), so perhaps that is the way to go?

As in toolkit changing to correct product.
Component: Themes → Themes
Product: SeaMonkey → Toolkit
QA Contact: themes → themes
(Assignee)

Comment 2

7 years ago
Created attachment 488364 [details] [diff] [review]
Add not disabled to _moz-menuactive line patch v0.1 [Checked in: Comment 4]

This patch:
* Adds a :not([disabled="true"]) to the _moz-menuactive line in the gnomestripe menu.css line.

Cannot see any regressions when tested in Firefox, fixes issue in SeaMonkey.
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #488364 - Flags: review?(dao)

Updated

7 years ago
Attachment #488364 - Flags: review?(dao) → review+
(Assignee)

Comment 3

7 years ago
Comment on attachment 488364 [details] [diff] [review]
Add not disabled to _moz-menuactive line patch v0.1 [Checked in: Comment 4]

Low impact, low risk theme fix - as far as I can see this will effect SeaMonkey only.
Attachment #488364 - Flags: approval2.0?
Attachment #488364 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 4

7 years ago
Comment on attachment 488364 [details] [diff] [review]
Add not disabled to _moz-menuactive line patch v0.1 [Checked in: Comment 4]

http://hg.mozilla.org/mozilla-central/rev/4563259585a2
Attachment #488364 - Attachment description: Add not disabled to _moz-menuactive line patch v0.1 → Add not disabled to _moz-menuactive line patch v0.1 [Checked in: Comment 4]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7

Updated

7 years ago
Target Milestone: mozilla2.0b7 → mozilla2.0b8

Updated

7 years ago
Depends on: 612234
You need to log in before you can comment on or make changes to this bug.