Closed Bug 609427 Opened 9 years ago Closed 9 years ago

extra ";" after NS_DECL_ISUPPORTS in nsContentPermissionHelper.h

Categories

(Core :: DOM: Core & HTML, defect)

x86
Solaris
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Details

Attachments

(1 file)

Caused a compile error with Solaris Studio.

"../../../dom/base/nsContentPermissionHelper.h", line 80: Error: "}" expected instead of ";".
"../../../dom/base/nsContentPermissionHelper.h", line 81: Error: "virtual" is not allowed here.
"../../../dom/base/nsContentPermissionHelper.h", line 81: Error: "virtual" is not allowed here.
"../../../dom/base/nsContentPermissionHelper.h", line 81: Error: "virtual" is not allowed here.
"../../../dom/base/nsContentPermissionHelper.h", line 81: Error: "virtual" is not allowed here.
"../../../dom/base/nsContentPermissionHelper.h", line 81: Error: "virtual" is not allowed here.
"../../../dom/base/nsContentPermissionHelper.h", line 81: Error: "virtual" is not allowed here.
"../../../dom/base/nsContentPermissionHelper.h", line 83: Error: A declaration was expected instead of "private".
"../../../dom/base/nsContentPermissionHelper.h", line 87: Error: A declaration was expected instead of "}".

....

Searched mozilla code base, we have extra ";" at these places.
http://mxr.mozilla.org/mozilla-central/search?string=%5E≈%5B+%5D*NS_DECL_.*%3B&regexp=1&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=mozilla-central

The extra ";" behind NS_DECL_NSICONTENTPERMISSIONREQUEST is ignorable by Solaris Studio.
But "NS_DECL_ISUPPORTS;" doesn't work.
Attached patch patchSplinter Review
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #488056 - Flags: review?(doug.turner)
Comment on attachment 488056 [details] [diff] [review]
patch

low risk.

Thank you Ginn.
Attachment #488056 - Flags: review?(doug.turner)
Attachment #488056 - Flags: review+
Attachment #488056 - Flags: approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/e4beaf723636
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.