609427 - extra ";" after NS_DECL_ISUPPORTS in nsContentPermissionHelper.h

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ginn Chen]

Caused a compile error with Solaris Studio.

"../../../dom/base/nsContentPermissionHelper.h", line 80: Error: "}" expected instead of ";".
"../../../dom/base/nsContentPermissionHelper.h", line 81: Error: "virtual" is not allowed here.
"../../../dom/base/nsContentPermissionHelper.h", line 81: Error: "virtual" is not allowed here.
"../../../dom/base/nsContentPermissionHelper.h", line 81: Error: "virtual" is not allowed here.
"../../../dom/base/nsContentPermissionHelper.h", line 81: Error: "virtual" is not allowed here.
"../../../dom/base/nsContentPermissionHelper.h", line 81: Error: "virtual" is not allowed here.
"../../../dom/base/nsContentPermissionHelper.h", line 81: Error: "virtual" is not allowed here.
"../../../dom/base/nsContentPermissionHelper.h", line 83: Error: A declaration was expected instead of "private".
"../../../dom/base/nsContentPermissionHelper.h", line 87: Error: A declaration was expected instead of "}".

....

Searched mozilla code base, we have extra ";" at these places.
http://mxr.mozilla.org/mozilla-central/search?string=%5E≈%5B+%5D*NS_DECL_.*%3B&regexp=1&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=mozilla-central

The extra ";" behind NS_DECL_NSICONTENTPERMISSIONREQUEST is ignorable by Solaris Studio.
But "NS_DECL_ISUPPORTS;" doesn't work.

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 488056 [details] [diff] [review]
patch

low risk.

Thank you Ginn.

Comment 3

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/e4beaf723636