609633 - mozmill profile takes binary ctor argument but then actually doesn't need it

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

the profile class takes a binary argument:

https://github.com/k0s/mozmill/blob/master/mozprofile/mozprofile/profile.py#L65

This used to be used in profile creation; however, this is no longer the case:

https://github.com/k0s/mozmill/blob/master/mozprofile/mozprofile/profile.py#L90

Since the binary is obtained from the runner and the runner needs the profile, this creates very convoluted logic where you get the binary from the runner class, construct the profile, then construct the runner.  And all for naught! 

Its not used, might as well wipe it

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The only situation I feel like is important when the profile has to know about the application, is when i.e. preferences have been changed between major versions of Firefox and we would have to supply different values for i.e. trunk vs. 1.9.2 builds.

Comment 2

[Jeff Hammel]

Currently, its not used at all.  If it is needed for something in the future, then we can put it in, hopefully in a sensible place, but currently it doesn't do anything

Comment 3

[Jeff Hammel]

Attachment: don't pass the binary argument to the profile

seems to fix the issue

Comment 4

[Heather Arthur [:harth]]

Comment on attachment 501205 [details] [diff] [review]
don't pass the binary argument to the profile

yes, lets take it out!

Comment 5

[Jeff Hammel]

pushed https://github.com/mozautomation/mozmill/commit/9cb2d5233943c986a429edcd48ba5d1cd24b0b8f