Incorrect syntax for ipc plugin tests in testsuite-targets.mk

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: sgreenlay, Assigned: sgreenlay)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
91 mochitest-ipcplugins:
92 #ifdef XP_MACOSX
93 #if defined(__i386__)
94         $(RUN_MOCHITEST) --setpref=dom.ipc.plugins.enabled.i386.test.plugin=true --test-path=modules/plugin/test
95 #elif defined(__x86_64__)
96         $(RUN_MOCHITEST) --setpref=dom.ipc.plugins.enabled.x86_64.test.plugin=true --test-path=modules/plugin/test
97 #elif defined(__ppc__)
98         $(RUN_MOCHITEST) --setpref=dom.ipc.plugins.enabled.ppc.test.plugin=true --test-path=modules/plugin/test
99 #endif
100 #else
101         $(RUN_MOCHITEST) --setpref=dom.ipc.plugins.enabled=true --test-path=modules/plugin/test
102 #endif

This does not work.
(Assignee)

Updated

7 years ago
Assignee: nobody → sgreenlay
(Assignee)

Comment 1

7 years ago
Created attachment 488274 [details] [diff] [review]
Plugin Test Makefile Fix (v1.0)
Attachment #488274 - Flags: review?(joshmoz)
(Assignee)

Updated

7 years ago
Summary: Incorrect testsuite-targets.mk syntax for plugin tests → Incorrect syntax for ipc plugin tests in testsuite-targets.mk
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED

Updated

7 years ago
Attachment #488274 - Flags: review?(joshmoz) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed

Updated

7 years ago
Attachment #488274 - Flags: approval2.0+

Comment 2

7 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/0e1a9600a81a
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.