609729 - Form helper makes commenting on tor.com impossible

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Josh Matthews [:jdm]]

It zooms away from the comment box every time you press a cjaracter.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Vivien - was this fixed by of the form helper zooming patches?

Comment 3

[Josh Matthews [:jdm]]

I saw this behaviour on today's nightly on my Galaxy S, if it's any help.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I'm not sure of what's happening right now, I'm trying to reduce tor.com to a usable testcase for the moment.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This bug is 2 bugs, the "zooms away" will be fixed by bug 479862, the jumps happen because the view position and content position are not synced.
If I forced them to be synced there is no jump when clicking.

There is a second bug thought, since the Form Helper is not showing at all for the comments box, it looks like Form Helper does not handle contentEditable!
I will fix the later in this bug.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch does not show the Form Helper UI, I don't think this make sense with contentEditable field, so the solution I proposed is to just zoom to the element.

I would like Madhava to confirm this is something we may want.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Madhava,
can I have your opinion on the last comment I've made? thanks.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

This patch show the FormHelper when needed (it does not resolve the first jump which will be fixed by an other bug as said in a previous comment)

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/7df5f19f8997

Comment 11

[Anna (Waverley)]

This bug is VERIFIED FIXED since the form helper feature was dropped off.

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110608 Firefox/7.0a1 Fennec/7.0a1 

Device: HTC Desire Z (Android 2.2)