609730 - Sync set up dialog has a run-on sentence: "Welcome, if you've never used Firefox Sync before, you will need to create a new account."

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot

STEPS TO REPRODUCE:
In a fresh profile, go to "sync" tab in Firefox Preferences, and click "Set Up Firefox Sync"

The dialog shown at that point says:

"Welcome, if you've never used Firefox Sync before, you will need to create a new account."

That sentence is grammatically incorrect. A comma is the wrong form of punctuation to have after "Welcome". Right now it almost sounds like we're only welcoming those people who've never used Firefox Sync before. :)

I think we want "Welcome!" or "Welcome;" or "Welcome --"

Comment 1

[Daniel Holbert [:dholbert]]

Fixing this would technically be a string change, but since it's only punctuation and not content, I'm hoping it might be a no-l10n-updates-needed type of string change.

Comment 2

[Philipp von Weitershausen [:philikon]]

I had it as "Welcome!" in one of the original revs but Faaborg made me change it to "Welcome," as per his mockups (bug 589980). CCing him for input.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

I don't really remember making the change, so I think what happened was I probably introduced the error in my mockup.  (possibly I was interested in toning down the enthusiasm of the exclamation point and ended up creating the run on sentence at the same time).  We can change it back to "Welcome!" if we can get the string change in.

Comment 5

[Dietrich Ayala (:dietrich)]

Given that we're past string-freeze now, blocking-. I think the path to take would be to get this patched and ask for approval.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: back to !

Who would review this?

Comment 7

[Philipp von Weitershausen [:philikon]]

Comment on attachment 491776 [details] [diff] [review]
back to !

Should definitely run this by Axel first whether or not we need to bump the entity, since it's only a punctuation change.

Comment 8

[Axel Hecht [:Pike]]

Looking through http://mxr.mozilla.org/l10n-central/search?string=setup.pickSetupType&find=syncSetup.dtd, it's borderline. Many locales kept the structure, asking for more input.

Among others, Kadir, I see you used the ! already, is that fixing the same grammar bug? Do you know if that spreads into other (germanic) languages?

Comment 9

[Kadir Topal [:atopal]]

Yeah, I'd say it's probably the same for most languages with an imperative form of the word and a punctuation mark.

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 491776 [details] [diff] [review]
back to !

In that case, I'm leaning towards entity change.

Comment 11

[Mike Connor [:mconnor]]

Let's just change the entity, and fix this however we feel is best.  Faaborg: string suggestion?

Comment 12

[Nigel Babu [:nigelb]]

What needs to happen here? String change and entity change?

Comment 13

[Philipp von Weitershausen [:philikon]]

(In reply to Nigel Babu [:nigelb] from comment #12)
> What needs to happen here? String change and entity change?

Yip

Comment 14

[Daniel Holbert [:dholbert]]

(In reply to Mike Connor [:mconnor] from comment #11)
> Let's just change the entity, and fix this however we feel is best. 
> Faaborg: string suggestion?

Strawman suggestion for string-change: "Welcome, if" --> "Welcome! If"  (from comment 0)

Comment 15

[Nigel Babu [:nigelb]]

Attachment: patch-v1

Changes the string and appropriate entity change.

Comment 16

[Allison Naaktgeboren :ally]

Comment on attachment 577343 [details] [diff] [review]
patch-v1

Review of attachment 577343 [details] [diff] [review]:
-----------------------------------------------------------------

looks functionally & grammatically correct to me.

nigelb, please attach a screen shot when you get a chance

Comment 17

[Nigel Babu [:nigelb]]

Attachment: patch-r+

Comment 18

[Allison Naaktgeboren :ally]

nigelb, congrats. \o/

tip: next time, please dont obsolete the patch with the r+ on it. It confuses people who would otherwise be happy to land your patch because it looks like you code is missing review. :)

Comment 19

[Richard Newman [:rnewman]]

Pushed:

https://hg.mozilla.org/services/services-central/rev/9dc80d92e1f3

Thanks for the patch, Nigel!

Comment 20

[Nigel Babu [:nigelb]]

Steps to test: On a profile without sync setup, go to Tools -> Setup Sync.  The text should be right below the Firefox Sync title of the dialog.

Comment 21

[Nigel Babu [:nigelb]]

Attachment: new-screenshot

Comment 22

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (Windows NT 6.1; rv:11.0a1) Gecko/20111205 Firefox/11.0a1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0a1) Gecko/20111205 Firefox/11.0a1
Mozilla/5.0 (X11; Linux i686; rv:11.0a1) Gecko/20111205 Firefox/11.0a1

Verified using the above builds - correct message is displayed at Sync setup, i.e.: "Welcome! If you've never used Firefox Sync before, you will need to create a new account." (as in the screenshot from comment #21)

Comment 23

[Gregory Szorc [:gps]]

Pushed to m-c: https://hg.mozilla.org/mozilla-central/rev/9dc80d92e1f3

Comment 24

[Tracy Walker [:tracy]]

verified on m-c builds of 20111223