609781 - tree.treeBoxObject.ensureRowIsVisible() does not resolve in widgets.js::clickTreeCell()

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

A number of modules have been observed failing in teardown:

./testSearch/testAddMozSearchProvider.js
./testSearch/testGetMoreSearchEngines.js
./testSearch/testOpenSearchAutodiscovery.js
./testSearch/testRemoveSearchEngine.js
./testSearch/testReorderSearchEngines.js
./testSearch/testRestoreDefaults.js

The common factor in all of these is a call to searchBar.restoreDefaultEngines() which in turn relies on widgets.clickTreeCell().

This function is failing with an error:

tree.treeBoxObject.ensureRowIsVisible is not a function (line 67)

So far, I've investigated and figured out this:

* tree does exist. I'm able to dump tree.id in code right before line 67.
* tree.treeBoxObject exists. I'm able to dump tree.treeBoxObject.height.
* DOM Inspector claims that ensureRowIsVisible() exists on treeBoxObject.

I'm unsure why it's not resolving from mozmill.

Comment 1

[Aaron Train [:aaronmt]]

This issue seems to have manifested itself in Minefield nightly builds starting from November 2nd onwards.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101102 Firefox/4.0b8pre

Good: f4ea6992e1c6
Bad: 45d6a73ef138

Built from http://hg.mozilla.org/mozilla-central/rev/45d6a73ef138

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f4ea6992e1c6&tochange=45d6a73ef138

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks for that information Aaron! I would tend to say it's because of the compartment patches. I will run a bisect to narrow it down.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The changes introduced with bug 607767 are causing those test failures:

The first bad revision is:
changeset:   56818:9ec3b67b2fd7
user:        Blake Kaplan <[e-mail]>
date:        Fri Oct 29 12:49:32 2010 -0700
summary:     bug 607767 - Fix rewrapping native objects across compartment boundaries. r=jst

Blake, is this an XPConnect regression?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #3)
> The first bad revision is:
> changeset:   56818:9ec3b67b2fd7
> user:        Blake Kaplan <[e-mail]>
> date:        Fri Oct 29 12:49:32 2010 -0700
> summary:     bug 607767 - Fix rewrapping native objects across compartment
> boundaries. r=jst

Peter or Blake, would it be possible that one of you could have a look at this regression? All of our search tests which are handling the search manager via a modal dialog are currently broken because of that lately change.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

This should be fixed by the checkin for bug 609139.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Latest debug tinderbox build looks great. Those failures are gone. I only end-up in an assertion+crash with the debug build.

Marking as fixed by bug 609139.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.