Closed
Bug 609794
Opened 14 years ago
Closed 14 years ago
Web console can cause the InstallTrigger getter to infinitely recur
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file)
|
2.21 KB,
patch
|
mossop
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
Because the web console creates sandbox objects whose proto is the window, 'this' might not have the InstallTrigger on it directly. This means that the 'delete' will silently do nothing and we'll infinitely recur when trying to return the actual value. This means that we have to walk the prototype chain actually looking for the window.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #488376 -
Flags: review?(dtownsend)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 488376 [details] [diff] [review] Proposed fix Replace the XXX with the right bug number and this looks good. Does it make sense to add a test for this?
Attachment #488376 -
Flags: review?(dtownsend) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
In trying to add a test, I found and filed bug 610078.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #488376 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #488376 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/47a88def011e
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•