Web console can cause the InstallTrigger getter to infinitely recur

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Because the web console creates sandbox objects whose proto is the window, 'this' might not have the InstallTrigger on it directly. This means that the 'delete' will silently do nothing and we'll infinitely recur when trying to return the actual value. This means that we have to walk the prototype chain actually looking for the window.
(Assignee)

Comment 1

8 years ago
Created attachment 488376 [details] [diff] [review]
Proposed fix
Attachment #488376 - Flags: review?(dtownsend)
Comment on attachment 488376 [details] [diff] [review]
Proposed fix

Replace the XXX with the right bug number and this looks good. Does it make sense to add a test for this?
Attachment #488376 - Flags: review?(dtownsend) → review+
(Assignee)

Comment 3

8 years ago
In trying to add a test, I found and filed bug 610078.
(Assignee)

Updated

8 years ago
Attachment #488376 - Flags: approval2.0?

Updated

8 years ago
Attachment #488376 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/47a88def011e
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Blocks: 595405
You need to log in before you can comment on or make changes to this bug.