Closed Bug 609952 Opened 9 years ago Closed 9 years ago
To Web Console functionality from Console APIObserver to HUDService
followup from gavin's review of bug 587734: > >+ function CAO_sendToWebConsole(aWebConsole, aLevel, aArguments) > > And this method seems like it reaches into HUDService/aWebConsole a bit too > much - seems like there should be a HUDService.logConsoleMessage(aHudID, > aLevel, aArguments) that contains most of this code (the existing > logConsoleMessage seems unused).
Assignee: ddahl → gavin.sharp
Status: NEW → ASSIGNED
Oh, and both patches are on top of the patch for bug 580618.
Comment on attachment 491073 [details] [diff] [review] patch >- * logs a message to the Heads Up Display that originates >- * in the nsIConsoleService >+ * Logs a message to the Heads Up Display that originates >+ * in the from the window.console API nit: remove "in the" from comment
Attachment #491073 - Flags: review?(ddahl) → review+
Comment on attachment 491073 [details] [diff] [review] patch a=beltzner
Attachment #491073 - Flags: approval2.0+
Landed with that change https://hg.mozilla.org/mozilla-central/rev/6e4659bdc601
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
You need to log in before you can comment on or make changes to this bug.