Closed Bug 610066 Opened 14 years ago Closed 14 years ago

Add src parameter to AMO API pings

Categories

(SeaMonkey :: Preferences, defect)

Product:
SeaMonkey
Component:
Preferences
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking2.0 final+)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.1b2
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: kairo, Assigned: kairo)

References

Details

(Keywords: fixed-seamonkey2.0.14)

Attachments

(2 files)

add src parameter [Checked in: Comment 3]
2.08 KB, patch
Callek
: review+
Details | Diff | Splinter Review
(Bv1-191) SeaMonkey 2.0.x part [Checked in: Comment 7]
2.12 KB, patch
Callek
: review+
Callek
: approval-seamonkey2.0.14+
Details | Diff | Splinter Review 
We'll want to port bug 602367 that added a src parameter to AMO requests. That bug stated that adding ?src=seamonkey for us is the right thing.
Here's the patch to add the ?src=seamonkey parameter to the same URLs as the FIrefox patch did.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #488756 - Flags: review?(neil)
Comment on attachment 488756 [details] [diff] [review]
add src parameter
[Checked in: Comment 3]

stealing review from Neil. r+
Attachment #488756 - Flags: review?(neil) → review+
Pushed as http://hg.mozilla.org/comm-central/rev/373b5b735fcd
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
Version: unspecified → Trunk
Comment on attachment 488756 [details] [diff] [review]
add src parameter
[Checked in: Comment 3]

This landed today for m-1.9.1.19.
Attachment #488756 - Flags: approval-seamonkey2.0.14?
Comment on attachment 488756 [details] [diff] [review]
add src parameter
[Checked in: Comment 3]

Happy to take this for branch, *but* can you please attach a branch specific patch; I know these urls have changed many times between trunk and branch.
Attachment #488756 - Flags: approval-seamonkey2.0.14? → approval-seamonkey2.0.14-
Attachment #488756 - Attachment description: add src parameter → add src parameter [Checked in: Comment 3]
Attachment #488756 - Flags: approval-seamonkey2.0.14-
Attachment #521328 - Flags: review+
Attachment #521328 - Flags: approval-seamonkey2.0.14?
Attachment #521328 - Flags: approval-seamonkey2.0.14+
Comment on attachment 521328 [details] [diff] [review]
(Bv1-191) SeaMonkey 2.0.x part
[Checked in: Comment 7]

http://hg.mozilla.org/releases/comm-1.9.1/rev/83f39848d2e4
Attachment #521328 - Attachment description: (Bv1-191) SeaMonkey 2.0.x part → (Bv1-191) SeaMonkey 2.0.x part [Checked in: Comment 7]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: