Closed Bug 610132 Opened 13 years ago Closed 13 years ago

Remove the BookmarksClient protocol

Categories

(Camino Graveyard :: Bookmarks, defect)

Product:
Camino Graveyard
Component:
Bookmarks
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

References

Details

Attachments

(1 file)

remove BookmarksClient protocol
21.39 KB, patch
mikepinkerton
: superreview+
Details | Diff | Splinter Review 
Currently there is a protocol defined for objects listening to bookmark notifications. This is kind of weird, forces the notification header to be included in headers, and reduces flexibility for clients.

As a first step for some cleanup I want to do for bookmark notifications, I'm removing the protocol, and renaming the header to match the new reality.
Attachment #488672 - Flags: superreview?(mikepinkerton)
Blocks: 610133
Comment on attachment 488672 [details] [diff] [review]
remove BookmarksClient protocol

sr=pink
Attachment #488672 - Flags: superreview?(mikepinkerton) → superreview+
Landed http://hg.mozilla.org/camino/rev/d6d385e0941b
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
OS: Mac OS X → Windows 7
Resolution: --- → FIXED
OS: Windows 7 → Mac OS X
Hg didn't handle this patch correctly; it has you doing a copy and remove instead of a move :(

It's not the end of the world with this header, but we should be very careful to ensure the right thing is happening in your commit tree if you end up doing other renames; it would suck to end up like http://groups.google.com/group/mozilla.dev.tree-management/browse_thread/thread/fe821769f03d09d6
You need to log in before you can comment on or make changes to this bug.