Clarify browser-places.js dependencies (was "Error: PlacesMenu is not defined")

RESOLVED INACTIVE

Status

()

defect
RESOLVED INACTIVE
9 years ago
11 months ago

People

(Reporter: tabutils+bugzilla, Unassigned)

Tracking

(Blocks 1 bug, {regression})

Trunk
x86
Windows XP
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Comment hidden (obsolete)
(Reporter)

Updated

9 years ago
Version: unspecified → Trunk
(Reporter)

Updated

9 years ago
Blocks: 560198
Comment hidden (obsolete)
Mano, the sidebar does not include global-scripts.inc where PlacesMenu is defined, but it imports browser.js...
I think either we make it use global-scripts.inc (removing the current browser.js and inlineSpellCheckUI.js imports), we move browserPlacesViews.js to PlacesOverlay or we workaround the issue since the sidebar is most likely not needing those views (by checking if PlacesMenu is in scope or by making a mock of it in the overlay).
What's your suggestion?

Comment 3

8 years ago
Seems fixed now in FF4 beta 10. At least the Bugzilla sidebar, that has been broken for all FF4 versions, is working now.
No, it's not fixed.
Bug 632411 solved the error, but we really need to clarify browser-places dependencies.
Summary: Error: PlacesMenu is not defined → Clarify browser-places.js dependencies (was "Error: PlacesMenu is not defined")
No longer blocks: 560198
No longer reproducible.
Version 	48.0a1
Build ID 	20160314030215
User Agent 	Mozilla/5.0 (Windows NT 5.1; rv:48.0) Gecko/20100101 Firefox/48.0
Considering this I will mark this issue as Resolved-WORKSFORME. If anyone can still reproduce it, feel free to reopen the issue and provide more information.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WORKSFORME
see comment 5.
The error doesn't happen anymore cause we put a workaround for it, but the dependencies problem still exists.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Assignee: asaf → nobody

Comment 8

11 months ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago11 months ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.