610234 - nsWindow.cpp includes gtkprivate.h

Status: RESOLVED DUPLICATE of bug 627699

(Core :: Widget: Gtk, defect)

Description

[Hussam Al-Tayeb]

User-Agent:       Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20100101 Firefox/4.0b8pre
Build Identifier: 

gtkprivate.h is no longer installed in gtk2 fro gtk2 version 2.24 
http://ftp.gnome.org/pub/GNOME/sources/gtk+/2.23/gtk+-2.23.1.changes
This breaks firefox build.

Reproducible: Always

Comment 1

[Reed Loden [:reed]]

See bug 339548, comment #68 and following for why this was used in the first place. Guess something else is going to have to be done to get around that now...

Comment 2

[Reed Loden [:reed]]

Looks like Ubuntu 11.04 is going to ship with GTK+ 2.24, which means this bug will affect that release. Requesting blocking.

Comment 3

[Chris Coulson]

gtkprivate.h was dropped in the 2.23.1 tarball by mistake (the 2.23.1 tarball wasn't based on the gtk-2.24 branch). I mentioned this to Matthias Clasen, and he rolled 2.23.2, whidh fixes this (ie, gtkprivate.h is back again).

gtkprivate.h is only going away in gtk 3

Comment 4

[Chris Coulson]

Note, we dropped 2.23.1 entirely from our archive once we noticed this, as it caused an ABI break too.

Comment 5

[Reed Loden [:reed]]

Ok, removing blocking request.

Comment 6

[Karl Tomlinson (:karlt)]

So http://ftp.gnome.org/pub/GNOME/sources/gtk+/2.23/gtk+-2.23.1.changes
diverges from those at http://git.gnome.org/browse/gtk+/log/?h=gtk-2-24
because gtk+-2.23.1.changes describe some other branch, I assume?
Or maybe the branch tag was moved.

Comment 7

[Chris Coulson]

Karl - yeah, the 2.23.1 release was created incorrectly, and didn't look like it came from the gtk-2-24 branch at all (or, at least I couldn't work out what commit the tarball was generated from when I tried to bisect an issue it was causing us).

The gtk-2.24 branch was never tagged 2.23.1, it seems like the tarball was rolled from a local branch that Matthias had.