610236 - tt-rss.org broken in recent fx4 nightlies

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Michael Monreal [:micmon]]

TinyTinyRSS (tt-rss.org) stopped working in Firefox 4 some days ago. It still works fine in Fx 3.6.

According to the maintainer, Fx4 has a broken localStorage.clear()

Comment 1

[Josh Matthews [:jdm]]

More details about the symptoms of the non-working site would be appreciated.  Further details about the brokenness of localStorage.clear() would also be appreciated.

Comment 2

[Boris Zbarsky [:bzbarsky]]

The only obvious change to clear() that I see since 3.6 is bug 501423.  Was the site relying on the old behavior from before the spec changes?

Michael, it would probably work best if you could put us in touch with the TinyTinyRSS maintainer directly...

Comment 3

[Michael Monreal [:micmon]]

Okay, there is discussion with the TT-RSS maintainer here:

http://tt-rss.org/forum/viewtopic.php?f=9&t=691&p=3211#p3211

You will find error output there and fox' assumption that localStorage.clear() is to broken somehow.

Note that today I was able to use the TT-RSS again, so I am not sure if fox changed anything to work around this or of the problem is another one. I already asked this on the given forum.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Ah, so the relevant part for clear() being broken is this (why wasn't it in comment 0?):

Exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMStorage.clear]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: http://online.tt-rss.org/tt-rss.js?1289146126 :: init_second_stage :: line 425" data: no]

The only thing that can return that error under clear() looks like various sql gunk under ClearStorage.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Note that some actual steps to reproduce would go a long way towards getting this sorted out; at that point we could just pin down where the exception is coming from.

Comment 6

[Michael Monreal [:micmon]]

When it fist started I was logged in and got the message each time I tried refreshing the feed list. After a logout and clearing the cache, I already got the message during the login process and was no longer able to get any further.

Given the fact that everything works totally fine today (without any more changes by fox) I am not sure if this can be tracked any further atm...

Comment 7

[Shawn Wilsher :sdwilsh]

(In reply to comment #4)
> The only thing that can return that error under clear() looks like various sql
> gunk under ClearStorage.
It's possible the database file is corrupted maybe.  That's about the only way I can see this failing offhand though... (it's also unlikely, but possible)

Comment 8

[Honza Bambas (:mayhemer)]

Might be related to bug 536544.

Comment 9

[Honza Bambas (:mayhemer)]

I'd like to investigate this.

Michael Monreal, how was the problem with localStorage.clear() originally reproduced?  Please step by step.  Thanks.

Comment 10

[Michael Monreal [:micmon]]

(In reply to comment #9)
> Michael Monreal, how was the problem with localStorage.clear() originally
> reproduced?  Please step by step.  Thanks.

A few days ago I began getting some "fatal error" message in tt-rss when refreshing the feed list or resizing the preview pane. I reported this on the tt-rss forum. A fix was checked in but at that point I got the new "fatal error" which fox tracked back to be related to localStrage. Maybe somehow the tt-rss version change triggered the data corruption?

Comment 11

[Michael Monreal [:micmon]]

FWIW I got the same (or similar?) error again now:

Fatal Exception

Error message:
Exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMStorage.getItem]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: http://online.tt-rss.org/viewfeed.js?1289244005 :: cache_check :: line 1777" data: no]
Function: preloadArticleUnderPointer()

Stack trace:
undefined

Comment 12

[Honza Bambas (:mayhemer)]

(In reply to comment #10)
> A few days ago I began getting some "fatal error" message in tt-rss when
> refreshing the feed list or resizing the preview pane. I reported this on the
> tt-rss forum. A fix was checked in but at that point I got the new "fatal
> error" which fox tracked back to be related to localStrage. Maybe somehow the
> tt-rss version change triggered the data corruption?

Please provide exact URLs I have to visit, if I have to have an account, what links I have to visit, click or, etc.  This doesn't give me much info.  Thanks.

Comment 13

[Michael Monreal [:micmon]]

(In reply to comment #12)
> Please provide exact URLs I have to visit, if I have to have an account, what
> links I have to visit, click or, etc.  This doesn't give me much info. Thanks.

I use the public server on online.tt-rss.org but it is closed for new users atm. Maybe you could get a test account. I already asked the maintainer about this.

Comment 14

[Johnny Stenback (:jst)]

This *sounds* like a regression, assuming it's not just a temporary database corruption problem. Blocking for now.

Comment 15

[Mounir Lamouri (:mounir)]

Honza, FWIW, I have a tt-rss instance one my server, let me know if you need an account.

Comment 16

[Honza Bambas (:mayhemer)]

(In reply to comment #15)
> Honza, FWIW, I have a tt-rss instance one my server, let me know if you need an
> account.

Yes, it would be great.  I don't have a chance to reproduce the problem locally otherwise.

Comment 17

[Mounir Lamouri (:mounir)]

(In reply to comment #16)
> (In reply to comment #15)
> > Honza, FWIW, I have a tt-rss instance one my server, let me know if you need an
> > account.
> 
> Yes, it would be great.  I don't have a chance to reproduce the problem locally
> otherwise.

I just sent you the informations by email.

Comment 18

[Honza Bambas (:mayhemer)]

(In reply to comment #17)
> I just sent you the informations by email.
Got it, thanks!

Comment 19

[Honza Bambas (:mayhemer)]

Mounir, it seems I'm not able to reproduce with the setup you gave me.  What are, for you, exact steps to reproduce?

Comment 20

[Mounir Lamouri (:mounir)]

(In reply to comment #19)
> Mounir, it seems I'm not able to reproduce with the setup you gave me.  What
> are, for you, exact steps to reproduce?

TBH, it's not clear to me how to reproduce the bug and I've never saw it (I'm using 3.6 on a daily basis).

According to the forum thread:
> I get a "Fatal Exception" after refreshing feeds (which seems to work nevertheless) or trying to resize the preview pane (which does not work):

Comment 21

[Honza Bambas (:mayhemer)]

(In reply to comment #20)
> > I get a "Fatal Exception" after refreshing feeds (which seems to work nevertheless) or trying to resize the preview pane (which does not work):

That's what I was trying, both.  Is the version you run different from which this bug was reported for?

Comment 22

[Michael Monreal [:micmon]]

(In reply to comment #21)
> Is the version you run different from which
> this bug was reported for?

Most likely, as online.tt-rss.org is often running unreleased code, it seems (I wasn't aware of this myself). FWIW, I did not run into this problem again after some point. It's hard to tell if the fix was done on the TT-RSS or Firefox side, though.

Comment 23

[Johnny Stenback (:jst)]

Doesn't sounds like there's enough information to move forward here atm. If this becomes better understood and the problem needs to be dealt with for Firefox 4, please renominate.

Comment 24

[Adam Williamson]

I'm seeing something similar, but wasn't sure if it was the same, so I filed a new bug - https://bugzilla.mozilla.org/show_bug.cgi?id=628691 . my own tt-rss instance failing to work with FF4b9 (but working with other browsers), different error message though.

Comment 25

[Honza Bambas (:mayhemer)]

Probably WFM or WONTFIX ?

Comment 26

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven't been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.