Closed Bug 610309 Opened 9 years ago Closed 9 years ago

Increase DEFAULT_MAX_STACK_SIZE to make "make check" happy on sparc.

Categories

(Core :: JavaScript Engine, defect)

Sun
Solaris
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: leon.sha, Assigned: leon.sha)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

I got 'too much recursion' on both sparc solaris and sparc linux, debug and release builds.
Attached patch patchSplinter Review
Assignee: general → leon.sha
Status: NEW → ASSIGNED
Attachment #488808 - Flags: review?(gal)
Comment on attachment 488808 [details] [diff] [review]
patch

That's a lot of stack. This is sparc only, so I hope you know what you are doing.
Attachment #488808 - Flags: review?(gal) → review+
A basic sparc call required 17*4 bytes of stack. Normally sparc have a bigger stack size.
(In reply to comment #2)
> Comment on attachment 488808 [details] [diff] [review]
> patch
> 
> That's a lot of stack. This is sparc only, so I hope you know what you are
> doing.
http://hg.mozilla.org/tracemonkey/rev/5f6bdc7a4f5c
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/5f6bdc7a4f5c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.