610310 - widgets and bar are too tall

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Dietrich Ayala (:dietrich)]

in latest sdk source from hg, and beta 6, the widgets are huge. must be a jetpack regression because it worked in beta 6 when it was released.

Comment 1

[Dietrich Ayala (:dietrich)]

pull request: https://github.com/mozilla/addon-sdk/pull/26

Comment 2

[Matěj Cepl]

Just confirming that this works for me with Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.2.12) Gecko/20101027 Fedora/3.6.12-1.fc14 Firefox/3.6.12 and this was broken for me on 3.6.* since the widget module was introduced in Jetpack-SDK.

Comment 3

[Graham Scott]

This patch has fixed the issue here too. I've tested in beta 6.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".

Comment 5

[Dietrich Ayala (:dietrich)]

Attachment: fix

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 492273 [details] [diff] [review]
fix

This seems mostly reasonable, although it fails to apply.  And I noticed one other issue:

>     test.assertEqual(widgetCount(), widgetStartCount + 1, "panel has correct number of child elements after widget construction");
> 
>+    // Test widget height
>+    test.assertEqual(widgetCount(), widgetStartCount, "panel has correct number of child elements after remove");

That doesn't look like a widget height test!

Comment 7

[Dietrich Ayala (:dietrich)]

Attachment: v2

unrotted, test fixed.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 493065 [details] [diff] [review]
v2

Looks good, seems to work, r=myk

Comment 9

[Dietrich Ayala (:dietrich)]

https://github.com/mozilla/addon-sdk/commit/0dc3971642b4c3e858c2354d7eaa5a4cec7267d9