Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Can't see full screen window controls, bookmark overflow chevron or tab or sidebar close button when using dark lwtheme

RESOLVED FIXED

Status

SeaMonkey
Themes
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

({classic})

Trunk
x86
Windows XP
classic

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Some lightweight themes, such as "Cheese grater - mini", have a very dark background and it this makes it difficult to see some of the UI.
(Assignee)

Comment 1

7 years ago
Created attachment 488894 [details] [diff] [review]
Proposed patch

* Makes the window controls visible by forcing them to have a plain background
* Tweaks the chevron and closebutton images so that instead of two black pixels
  they have one black and one dark grey pixel. (Note that I used #808080 as my
  dark grey, while Firefox went for #999999 in their chevron.)
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #488894 - Flags: review?(iann_bugzilla)
(In reply to comment #1)
> Created attachment 488894 [details] [diff] [review]
> Proposed patch
> 
> * Makes the window controls visible by forcing them to have a plain background

Too bad we can't apply a rule based on whether the lwtheme has a dark background. We can only check whether the text color is bright or dark, and a bright text color can go with both a dark and a bright lwtheme (with text-shadow in the latter case). :-( For example I think "samotne drzewo" looks better without the change. But having clearly visible controls is more important of course.

Since we cannot apply transparency to -moz-Dialog either (at least AFAIK we could only use rgba(r,g,b,a), but that would mean not using the OS colors), f=me for this if you want it (the chevron/closebutton changes were so subtle that I overlooked them initially, but I appreciate them).
(Assignee)

Updated

7 years ago
Summary: Can't see full screen window controls, bookmark overflow chevron or tab close button when using dark lwtheme → Can't see full screen window controls, bookmark overflow chevron or tab or sidebar close button when using dark lwtheme

Updated

7 years ago
Attachment #488894 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 3

7 years ago
Pushed changeset 50d164d40d14 to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.