Closed Bug 610436 Opened 9 years ago Closed 9 years ago

Add an inline GetValueChanged() in nsHTMLInputElement

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: mounir, Assigned: mounir)

Details

Attachments

(1 file)

Like GetCheckedChanged()
Attached patch Patch v1Splinter Review
This is also making GetCheckedChanged explicitly inline.
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #488998 - Flags: review?(bzbarsky)
Comment on attachment 488998 [details] [diff] [review]
Patch v1

s/if/whether/ and r=me
Attachment #488998 - Flags: review?(bzbarsky) → review+
Attachment #488998 - Flags: approval2.0?
Comment on attachment 488998 [details] [diff] [review]
Patch v1

Please don't nominate patches for approval without explaining why they are being nominated, what the risks and rewards of the patch are.
Attachment #488998 - Flags: approval2.0?
There are no risks, it's only refactoring. It was requested by Boris while reviewing bug 605124.
Comment on attachment 488998 [details] [diff] [review]
Patch v1

Re-requesting approval per comment 4.
Attachment #488998 - Flags: approval2.0?
Attachment #488998 - Flags: approval2.0? → approval2.0+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/50dda7cdd3e8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.