The default bug view has changed. See this FAQ.

Bookmarks and Address Book sidebars' search fields miss placeholder attribute

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
Sidebar
--
minor
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.1b2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
Created attachment 489010 [details] [diff] [review]
patch

We have four default sidebars. All of them contain quick search fields, but only two of those show a description when not focused (which is achieved using the placeholder attribute on the textbox elements).

OK:
suite/common/search/search-panel.xul
suite/common/history/history-panel.xul

To do:
mailnews/addrbook/content/addressbook-panel.xul
suite/common/bookmarks/bm-panel.xul
Attachment #489010 - Flags: superreview?(neil)
Attachment #489010 - Flags: review?(mnyromyr)

Comment 1

7 years ago
I'm not convinced that the address book sidebar panel needs placeholder text because the search field is already part of a phrase.
(Assignee)

Comment 2

7 years ago
(In reply to comment #1)
> I'm not convinced that the address book sidebar panel needs placeholder text
> because the search field is already part of a phrase.

Or we could leave out the "Search " prefix, i.e. make it "for: [Name or Email    ]".

Comment 3

7 years ago
Comment on attachment 489010 [details] [diff] [review]
patch

OK, that would work, but you'd want to change the select addresses dialog too.

As for bookmarks, if you're using placeholder then you can lose the label.
Attachment #489010 - Flags: superreview?(neil) → superreview-
(Assignee)

Comment 4

7 years ago
Created attachment 489325 [details] [diff] [review]
patch v2
Attachment #489010 - Attachment is obsolete: true
Attachment #489325 - Flags: superreview?(neil)
Attachment #489325 - Flags: review?(mnyromyr)
Attachment #489010 - Flags: review?(mnyromyr)

Comment 5

7 years ago
Comment on attachment 489325 [details] [diff] [review]
patch v2

>--- a/mailnews/addrbook/content/abSelectAddressesDialog.xul
>+++ b/mailnews/addrbook/content/abSelectAddressesDialog.xul
[Odd, why are these files not in suite/mailnews/addrbook?]

>+<!ENTITY for.placeholder                     "Name and Email"> 
Shouldn't this be "Name or Email"? sr=me with that fixed.
Nit: trailing space.
Attachment #489325 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 6

7 years ago
Created attachment 489517 [details] [diff] [review]
patch v2a [Checkin: comment 7]

(In reply to comment #5)
> >+++ b/mailnews/addrbook/content/abSelectAddressesDialog.xul
> [Odd, why are these files not in suite/mailnews/addrbook?]

I guess because no-one cared to file and fix a bug for it yet, even though some noticed? Cf. bug 507622 comment 0. Filed bug 611029.

> >+<!ENTITY for.placeholder                     "Name and Email"> 
> Shouldn't this be "Name or Email"? sr=me with that fixed.

I wanted to achieve consistency with the placeholder of the Address Book main window's search field but missed the difference in context.
Attachment #489325 - Attachment is obsolete: true
Attachment #489517 - Flags: superreview+
Attachment #489517 - Flags: review?
Attachment #489325 - Flags: review?(mnyromyr)

Updated

7 years ago
Attachment #489517 - Flags: review? → review+
(Assignee)

Comment 7

7 years ago
Comment on attachment 489517 [details] [diff] [review]
patch v2a [Checkin: comment 7]

http://hg.mozilla.org/comm-central/rev/7865178cde4a
Attachment #489517 - Attachment description: patch v2a → patch v2a [Checkin: comment 7]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
You need to log in before you can comment on or make changes to this bug.