610517 - Bookmarks and Address Book sidebars' search fields miss placeholder attribute

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch

We have four default sidebars. All of them contain quick search fields, but only two of those show a description when not focused (which is achieved using the placeholder attribute on the textbox elements).

OK:
suite/common/search/search-panel.xul
suite/common/history/history-panel.xul

To do:
mailnews/addrbook/content/addressbook-panel.xul
suite/common/bookmarks/bm-panel.xul

Comment 1

[[e-mail]]

I'm not convinced that the address book sidebar panel needs placeholder text because the search field is already part of a phrase.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #1)
> I'm not convinced that the address book sidebar panel needs placeholder text
> because the search field is already part of a phrase.

Or we could leave out the "Search " prefix, i.e. make it "for: [Name or Email    ]".

Comment 3

[[e-mail]]

Comment on attachment 489010 [details] [diff] [review]
patch

OK, that would work, but you'd want to change the select addresses dialog too.

As for bookmarks, if you're using placeholder then you can lose the label.

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch v2

Comment 5

[[e-mail]]

Comment on attachment 489325 [details] [diff] [review]
patch v2

>--- a/mailnews/addrbook/content/abSelectAddressesDialog.xul
>+++ b/mailnews/addrbook/content/abSelectAddressesDialog.xul
[Odd, why are these files not in suite/mailnews/addrbook?]

>+<!ENTITY for.placeholder                     "Name and Email"> 
Shouldn't this be "Name or Email"? sr=me with that fixed.
Nit: trailing space.

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch v2a [Checkin: comment 7]

(In reply to comment #5)
> >+++ b/mailnews/addrbook/content/abSelectAddressesDialog.xul
> [Odd, why are these files not in suite/mailnews/addrbook?]

I guess because no-one cared to file and fix a bug for it yet, even though some noticed? Cf. bug 507622 comment 0. Filed bug 611029.

> >+<!ENTITY for.placeholder                     "Name and Email"> 
> Shouldn't this be "Name or Email"? sr=me with that fixed.

I wanted to achieve consistency with the placeholder of the Address Book main window's search field but missed the difference in context.

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 489517 [details] [diff] [review]
patch v2a [Checkin: comment 7]

http://hg.mozilla.org/comm-central/rev/7865178cde4a