610582 - TMFLAGS=tracer is broken

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Current tip TM

STEPS TO REPRODUCE:
1)  Build debug shell
2)  Stick https://bugzilla.mozilla.org/attachment.cgi?id=489101 in ~/test.js
2)  env TMFLAGS=tracer js -j ~/test.js

EXPECTED RESULTS: Some information on side exits

ACTUAL RESULTS:
Assertion failure: str, at /Users/bzbarsky/mozilla/tracemonkey/mozilla/js/src/jsval.h:603

Comment 1

[Boris Zbarsky [:bzbarsky]]

And in particular, js::TraceRecorder::record_EnterFrame does this:

  js_AtomToPrintableString(cx, cx->fp()->fun()->atom)

but cx->fp()->fun()->atom is null, so we propagate the null all the way through js_ValueToPrintableString to js::StringValue to js::Value::setString to STRING_TO_JSVAL_IMPL where we assert.

Comment 2

[Boris Zbarsky [:bzbarsky]]

This particular function looks like this, I think:

    rotateLeft: function(n, s) {
        var t4 = ( n << s ) | (n >>> (32 - s));
        return t4;
    },

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix TMFLAGS=tracer for anonymous functions.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/tracemonkey/rev/c1c10304f991

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/c1c10304f991