Closed Bug 610602 Opened 9 years ago Closed 8 years ago

TBPL should not depend on a hardcoded timezone offset

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Swatinem, Assigned: mbrubeck)

References

Details

Attachments

(1 file, 1 obsolete file)

It should somehow dynamically know if we have daylight savings times in effect or not and offset the tinderbox timestamps accordingly instead of hardcoding that offset.
This would be particularly nice to fix now that we don't control our own updating destiny, and every changeover is going to be accompanied by me pleading with IT to cover up for the fact that we have a hardcoded timezone offset.
OS: Linux → All
Hardware: x86_64 → All
Attached patch patch (obsolete) — Splinter Review
I hate Daylight Saving Time.
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #609947 - Flags: review?(philringnalda)
Attached patch patch v2Splinter Review
Oh thank god I found a more readable way to write this.
Attachment #609947 - Attachment is obsolete: true
Attachment #609951 - Flags: review?(philringnalda)
Attachment #609947 - Flags: review?(philringnalda)
Comment on attachment 609951 [details] [diff] [review]
patch v2

I don't just hate daylight saving time, I have a mental block for time differences in general, so if you've got the signs swapped, I'd never figure it out.
Attachment #609951 - Flags: review?(philringnalda) → review?(arpad.borsos)
Comment on attachment 609951 [details] [diff] [review]
patch v2

Review of attachment 609951 [details] [diff] [review]:
-----------------------------------------------------------------

Nice trick to get the “First/Second Sunday”.
And good job providing tests! :-)
Attachment #609951 - Flags: review?(arpad.borsos) → review+
https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/bd4577ff8c56
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
mbrubeck++++++++++++
Depends on: 743595
Blocks: 919047
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.