610602 - TBPL should not depend on a hardcoded timezone offset

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Arpad Borsos [:Swatinem]]

It should somehow dynamically know if we have daylight savings times in effect or not and offset the tinderbox timestamps accordingly instead of hardcoding that offset.

Comment 1

[Phil Ringnalda (:philor)]

This would be particularly nice to fix now that we don't control our own updating destiny, and every changeover is going to be accompanied by me pleading with IT to cover up for the fact that we have a hardcoded timezone offset.

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch

I hate Daylight Saving Time.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

Oh thank god I found a more readable way to write this.

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 609951 [details] [diff] [review]
patch v2

I don't just hate daylight saving time, I have a mental block for time differences in general, so if you've got the signs swapped, I'd never figure it out.

Comment 5

[Arpad Borsos [:Swatinem]]

Comment on attachment 609951 [details] [diff] [review]
patch v2

Review of attachment 609951 [details] [diff] [review]:
-----------------------------------------------------------------

Nice trick to get the “First/Second Sunday”.
And good job providing tests! :-)

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/bd4577ff8c56

Comment 7

[Markus Stange [:mstange]]

mbrubeck++++++++++++