610642 - In function ‘JSBool JSID_IS_ZERO(jsid)’: warning: NULL used in arithmetic

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Mats Palmgren (:mats)]

For just about every file I compile I get:
../../dist/include/jsapi.h: In function ‘JSBool JSID_IS_ZERO(jsid)’:
../../dist/include/jsapi.h:332: warning: NULL used in arithmetic

http://hg.mozilla.org/mozilla-central/annotate/7fe44a9f25d4/js/src/jsapi.h#l332

# gcc --version
gcc-4.4.real (Ubuntu 4.4.3-4ubuntu5) 4.4.3

x86-64 Linux

Comment 1

[Josh Aas]

Also happens on Mac OS X.

Comment 2

[Daniel Holbert [:dholbert] (blocking needinfo/review, due to AFK on parental leave, returning Jan 21)]

Attachment: fix: s/NULL/0/

Trivial fix: just replace
   JSID_BITS(id) == NULL
with
   JSID_BITS(id) == 0

Other preexisting macros in the same file already check against 0.  This just makes the body of this new macro "JSID_IS_ZERO" (added yesterday) match that convention.

Comment 3

[Daniel Holbert [:dholbert] (blocking needinfo/review, due to AFK on parental leave, returning Jan 21)]

Comment on attachment 489225 [details] [diff] [review]
fix: s/NULL/0/

Requesting approval to land. Trivial fix (s/NULL/0/ one-liner), fixes a very-spammy build warning introduced yesterday.

Comment 4

[Daniel Holbert [:dholbert] (blocking needinfo/review, due to AFK on parental leave, returning Jan 21)]

Landed: http://hg.mozilla.org/mozilla-central/rev/924808901dce

Comment 5

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

http://hg.mozilla.org/tracemonkey/rev/e2f64f43c7e1

Comment 6

[Daniel Holbert [:dholbert] (blocking needinfo/review, due to AFK on parental leave, returning Jan 21)]

ah, thanks -- I didn't realize this was an issue on tracemonkey too, since bug 601457 just mentioned an m-c checkin.