Closed
Bug 610642
Opened 15 years ago
Closed 15 years ago
In function ‘JSBool JSID_IS_ZERO(jsid)’: warning: NULL used in arithmetic
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: MatsPalmgren_bugz, Assigned: dholbert)
References
Details
(Keywords: regression, Whiteboard: [build_warning] fixed-in-tracemonkey)
Attachments
(1 file)
738 bytes,
patch
|
dmandelin
:
review+
shaver
:
approval2.0+
|
Details | Diff | Splinter Review |
For just about every file I compile I get:
../../dist/include/jsapi.h: In function ‘JSBool JSID_IS_ZERO(jsid)’:
../../dist/include/jsapi.h:332: warning: NULL used in arithmetic
http://hg.mozilla.org/mozilla-central/annotate/7fe44a9f25d4/js/src/jsapi.h#l332
# gcc --version
gcc-4.4.real (Ubuntu 4.4.3-4ubuntu5) 4.4.3
x86-64 Linux
Assignee | ||
Comment 2•15 years ago
|
||
Trivial fix: just replace
JSID_BITS(id) == NULL
with
JSID_BITS(id) == 0
Other preexisting macros in the same file already check against 0. This just makes the body of this new macro "JSID_IS_ZERO" (added yesterday) match that convention.
Assignee | ||
Updated•15 years ago
|
Attachment #489225 -
Flags: review? → review?(dmandelin)
Updated•15 years ago
|
Attachment #489225 -
Flags: review?(dmandelin) → review+
Assignee | ||
Comment 3•15 years ago
|
||
Comment on attachment 489225 [details] [diff] [review]
fix: s/NULL/0/
Requesting approval to land. Trivial fix (s/NULL/0/ one-liner), fixes a very-spammy build warning introduced yesterday.
Attachment #489225 -
Flags: approval2.0?
Updated•15 years ago
|
Attachment #489225 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning]
Comment 5•15 years ago
|
||
Whiteboard: [build_warning] → [build_warning] fixed-in-tracemonkey
Assignee | ||
Comment 6•15 years ago
|
||
ah, thanks -- I didn't realize this was an issue on tracemonkey too, since bug 601457 just mentioned an m-c checkin.
You need to log in
before you can comment on or make changes to this bug.
Description
•